Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: src/elements.h

Issue 1188073003: Return void from array setters since the return value needs to be ignored (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index 310891ab1e030be14f8413dcef21680f4471a2cd..3067e56adb9dc189677ec524a3afd64a83fe3685 100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -43,9 +43,8 @@ class ElementsAccessor {
return HasElement(holder, key, handle(holder->elements()));
}
- inline Handle<Object> Set(Handle<JSObject> holder, uint32_t key,
- Handle<Object> value) {
- return Set(holder, key, handle(holder->elements()), value);
+ inline void Set(Handle<JSObject> holder, uint32_t key, Handle<Object> value) {
+ Set(holder, key, handle(holder->elements()), value);
}
// Returns the element with the specified key or undefined if there is no such
@@ -180,9 +179,9 @@ class ElementsAccessor {
uint32_t index) = 0;
virtual bool HasIndex(FixedArrayBase* backing_store, uint32_t key) = 0;
- virtual Handle<Object> Set(Handle<JSObject> holder, uint32_t key,
- Handle<FixedArrayBase> backing_store,
- Handle<Object> value) = 0;
+ virtual void Set(Handle<JSObject> holder, uint32_t key,
+ Handle<FixedArrayBase> backing_store,
+ Handle<Object> value) = 0;
private:
static ElementsAccessor** elements_accessors_;
« no previous file with comments | « no previous file | src/elements.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698