Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: src/objects-inl.h

Issue 1188073003: Return void from array setters since the return value needs to be ignored (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index c3ee543b7c4e8c6666257688cef2d5db5be1229d..53e72cb4b19ed7e62538b517509b69656903c2be 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -4036,9 +4036,9 @@ Handle<Object> FixedTypedArray<Traits>::get(
template <class Traits>
-Handle<Object> FixedTypedArray<Traits>::SetValue(
- Handle<JSObject> holder, Handle<FixedTypedArray<Traits> > array,
- uint32_t index, Handle<Object> value) {
+void FixedTypedArray<Traits>::SetValue(Handle<JSObject> holder,
+ Handle<FixedTypedArray<Traits> > array,
+ uint32_t index, Handle<Object> value) {
ElementType cast_value = Traits::defaultValue();
Handle<JSArrayBufferView> view = Handle<JSArrayBufferView>::cast(holder);
if (!view->WasNeutered()) {
@@ -4057,7 +4057,6 @@ Handle<Object> FixedTypedArray<Traits>::SetValue(
array->set(index, cast_value);
}
}
- return Traits::ToHandle(array->GetIsolate(), cast_value);
}
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698