Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1187943006: Revert of Componentize HistoryURLProvider/ScoredHistoryMatch. (Closed)

Created:
5 years, 6 months ago by phoglund_chromium
Modified:
5 years, 6 months ago
Reviewers:
Peter Kasting, blundell
CC:
chromium-reviews, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@prepare_history_url_provider_for_c14n
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Componentize HistoryURLProvider/ScoredHistoryMatch. (patchset #3 id:60001 of https://codereview.chromium.org/1181113005/) Reason for revert: Very speculative revert to attempt to fix ChromeBlacklistTrialTest.BlacklistDisabledRun on win unit_tests. If this doesn't fix it, https://codereview.chromium.org/1175603002 is next to try. Original issue's description: > Componentize HistoryURLProvider/ScoredHistoryMatch. > > No changes are needed. > > BUG=371538 > > Committed: https://crrev.com/66c202106ea7ab3f3c078a5edfb4abf0d23cee94 > Cr-Commit-Position: refs/heads/master@{#334780} TBR=pkasting@chromium.org,blundell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2919 lines, -2924 lines) Patch
M chrome/browser/autocomplete/autocomplete_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_quick_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/autocomplete/history_url_provider.h View 1 chunk +344 lines, -0 lines 0 comments Download
A chrome/browser/autocomplete/history_url_provider.cc View 1 chunk +1170 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/in_memory_url_index.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/autocomplete/scored_history_match.h View 1 chunk +196 lines, -0 lines 0 comments Download
A chrome/browser/autocomplete/scored_history_match.cc View 1 chunk +699 lines, -0 lines 0 comments Download
A chrome/browser/autocomplete/scored_history_match_unittest.cc View 1 chunk +492 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/url_index_private_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/omnibox/omnibox_edit_model.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 4 chunks +5 lines, -4 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/omnibox.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M components/omnibox/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download
D components/omnibox/history_url_provider.h View 1 chunk +0 lines, -344 lines 0 comments Download
D components/omnibox/history_url_provider.cc View 1 chunk +0 lines, -1170 lines 0 comments Download
D components/omnibox/scored_history_match.h View 1 chunk +0 lines, -196 lines 0 comments Download
D components/omnibox/scored_history_match.cc View 1 chunk +0 lines, -699 lines 0 comments Download
D components/omnibox/scored_history_match_unittest.cc View 1 chunk +0 lines, -492 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
phoglund_chromium
Created Revert of Componentize HistoryURLProvider/ScoredHistoryMatch.
5 years, 6 months ago (2015-06-17 13:13:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1187943006/1
5 years, 6 months ago (2015-06-17 13:14:13 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 13:14:56 UTC) #4
Failed to apply patch for chrome/browser/autocomplete/history_quick_provider.cc:
While running git apply --index -3 -p1;
  error: patch failed: chrome/browser/autocomplete/history_quick_provider.cc:16
  Falling back to three-way merge...
  Applied patch to 'chrome/browser/autocomplete/history_quick_provider.cc' with
conflicts.
  U chrome/browser/autocomplete/history_quick_provider.cc

Patch:       chrome/browser/autocomplete/history_quick_provider.cc
Index: chrome/browser/autocomplete/history_quick_provider.cc
diff --git a/chrome/browser/autocomplete/history_quick_provider.cc
b/chrome/browser/autocomplete/history_quick_provider.cc
index
d67dab8c33e56372af08ec801deb4d3fb65d9d34..705b3f5ebdaa63d13f8f6b49c6316c374e3d5971
100644
--- a/chrome/browser/autocomplete/history_quick_provider.cc
+++ b/chrome/browser/autocomplete/history_quick_provider.cc
@@ -16,6 +16,7 @@
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"
+#include "chrome/browser/autocomplete/history_url_provider.h"
 #include "chrome/browser/autocomplete/in_memory_url_index.h"
 #include "chrome/browser/bookmarks/bookmark_model_factory.h"
 #include "chrome/browser/profiles/profile.h"
@@ -30,7 +31,6 @@
 #include "components/metrics/proto/omnibox_input_type.pb.h"
 #include "components/omnibox/autocomplete_match_type.h"
 #include "components/omnibox/autocomplete_result.h"
-#include "components/omnibox/history_url_provider.h"
 #include "components/omnibox/in_memory_url_index_types.h"
 #include "components/omnibox/omnibox_field_trial.h"
 #include "components/search_engines/template_url.h"

Powered by Google App Engine
This is Rietveld 408576698