views: Move TOOLKIT_VIEWS definition in //ui/views/ from root.

views: Move TOOLKIT_VIEWS definition in //ui/views/ from root.

If 'toolkit_views' gyp/gn flag is toggled, then it shouldn't cause targets that
do not depend on views to be rebuilt. To make this happen, remove the definition
of the TOOLKIT_VIEWS flag from the top-level config into a config in views, so
that only targets that explicitly depend on views get the define, and are
affected by the switch.

BUG=500004
R=ben@chromium.org, sky@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/c13fc9ff0aedca62ebfdfc27d44c6b5ac204c9d8

[sadrul, 2015-06-16 21:37:52]

sadrul@chromium.org changed reviewers:
+ ben@chromium.org, sky@chromium.org

[sadrul, 2015-06-16 21:37:53]

You can ignore the webui changes. Those are being reviewed in a separate CL
(https://codereview.chromium.org/1185363002/)

[Ben Goodger (Google), 2015-06-16 21:52:09]

lgtm

https://codereview.chromium.org/1175603002/diff/60001/ui/views/BUILD.gn
File ui/views/BUILD.gn (right):

https://codereview.chromium.org/1175603002/diff/60001/ui/views/BUILD.gn#newco...
ui/views/BUILD.gn:14: config("views_flags") {
"flags"

namespacing is implicit by virtue of this file being in this directory.

[sky, 2015-06-16 23:14:29]

LGTM

[sadrul, 2015-06-17 01:46:01]

https://codereview.chromium.org/1175603002/diff/60001/ui/views/BUILD.gn
File ui/views/BUILD.gn (right):

https://codereview.chromium.org/1175603002/diff/60001/ui/views/BUILD.gn#newco...
ui/views/BUILD.gn:14: config("views_flags") {
On 2015/06/16 21:52:09, Ben Goodger (Google) wrote:
> "flags"
> 
> namespacing is implicit by virtue of this file being in this directory.

Done.

[sadrul, 2015-06-17 03:34:46]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2015-06-17 03:34:46]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1175603002/#ps100001
(title: "for-land")

[commit-bot: I haz the power, 2015-06-17 03:35:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175603002/100001

[commit-bot: I haz the power, 2015-06-17 06:07:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-17 06:07:40]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2015-06-17 06:16:16]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-06-17 06:16:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175603002/100001

[sadrul, 2015-06-17 07:08:37]

Committed patchset #6 (id:100001) manually as
c13fc9ff0aedca62ebfdfc27d44c6b5ac204c9d8 (presubmit successful).

[phoglund_chromium, 2015-06-17 13:41:55]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1192583002/ by phoglund@chromium.org.

The reason for reverting is: Speculative revert to fix win unit_test failures.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/bui....

[sadrul, 2015-06-18 04:19:16]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-06-18 04:21:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1175603002/100001

[sadrul, 2015-06-18 04:21:46]

The CQ bit was unchecked by sadrul@chromium.org