[MIPS] Add thread-pointer to data addressing register list.

src/trusted/validator_mips/ncvalidate.cc

Index: src/trusted/validator_mips/ncvalidate.cc
diff --git a/src/trusted/validator_mips/ncvalidate.cc b/src/trusted/validator_mips/ncvalidate.cc
index 8696059ae7ea437a839c2e116bd063429152278a..e26ebd253e77359a5c82d96691283a0739c9c813 100644
--- a/src/trusted/validator_mips/ncvalidate.cc
+++ b/src/trusted/validator_mips/ncvalidate.cc
@@ -17,9 +17,7 @@
 
 using nacl_mips_val::SfiValidator;
 using nacl_mips_val::CodeSegment;
-using nacl_mips_dec::Register;
-using nacl_mips_dec::RegisterList;
-using nacl_mips_dec::kRegisterStack;
+using nacl_mips_dec::kRegListDataAddr;

[Mark Seaborn, 2013/01/15 16:51:36]

Wouldn't it be better to use the fully-qualified name below rather than use
"using"?

 using nacl_mips_dec::kRegListReserved;
 using std::vector;
 
@@ -91,7 +89,7 @@ int NCValidateSegment(uint8_t *mbase, uint32_t vbase, size_t size,
       1U * (1 << NACL_MAX_ADDR_BITS),  // bytes of data space // keep in sync w/

[Mark Seaborn, 2013/01/15 16:51:36]

Hmm, as an aside, this code is duplicated between here and ncval.cc.  Maybe you
could clean this up in a separate change?

[JF, 2013/01/15 17:03:03]

This code should stay, and ncval.cc should be deleted: Vlad created
src/trusted/validator/driver/ncval.cc which is a validator driver that builds on
all hosts and can handle any target. This should be the one and only stand-alone
validator :-)

[petarj, 2013/01/22 22:57:30]

I will clean it up in a separate change.
So we do not the local ncval.cc anymore, and will be using
driver/ncval.cc only, right?

                                        // SConstruct: irt_compatible_rodata_addr
       kRegListReserved,                // read only register(s)
-      RegisterList(kRegisterStack));   // data addressing register(s)
+      kRegListDataAddr);               // data addressing register(s)
   bool success = false;
 
   vector<CodeSegment> segments;