[MIPS] Add thread-pointer to data addressing register list.

src/trusted/validator_mips/ncvalidate.cc

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "native_client/src/trusted/validator_mips/ncvalidate.h"
 
 #include <vector>
 
 #include "native_client/src/include/nacl_string.h"
 #include "native_client/src/include/portability.h"
 #include "native_client/src/trusted/service_runtime/arch/mips/sel_ldr_mips.h"
 #include "native_client/src/trusted/cpu_features/arch/mips/cpu_mips.h"
 #include "native_client/src/trusted/validator_mips/model.h"
 #include "native_client/src/trusted/validator_mips/validator.h"
 
 using nacl_mips_val::SfiValidator;
 using nacl_mips_val::CodeSegment;
-using nacl_mips_dec::Register;
-using nacl_mips_dec::RegisterList;
-using nacl_mips_dec::kRegisterStack;
+using nacl_mips_dec::kRegListDataAddr;

[Mark Seaborn, 2013/01/15 16:51:36]

Wouldn't it be better to use the fully-qualified name below rather than use
"using"?

 using nacl_mips_dec::kRegListReserved;
 using std::vector;
 
 
 class EarlyExitProblemSink : public nacl_mips_val::ProblemSink {
  private:
   bool problems_;
 
  public:
   EarlyExitProblemSink() : nacl_mips_val::ProblemSink(), problems_(false) {}
@@ skipping 48 matching lines @@
   }
 };
 
 EXTERN_C_BEGIN
 
 int NCValidateSegment(uint8_t *mbase, uint32_t vbase, size_t size,
                       bool stubout_mode) {
   SfiValidator validator(
       16,                              // 64,  // bytes per bundle
       1U * NACL_DATA_SEGMENT_START,    // bytes of code space
       1U * (1 << NACL_MAX_ADDR_BITS),  // bytes of data space // keep in sync w/

[Mark Seaborn, 2013/01/15 16:51:36]

Hmm, as an aside, this code is duplicated between here and ncval.cc.  Maybe you
could clean this up in a separate change?

[JF, 2013/01/15 17:03:03]

This code should stay, and ncval.cc should be deleted: Vlad created
src/trusted/validator/driver/ncval.cc which is a validator driver that builds on
all hosts and can handle any target. This should be the one and only stand-alone
validator :-)

[petarj, 2013/01/22 22:57:30]

I will clean it up in a separate change.
So we do not the local ncval.cc anymore, and will be using
driver/ncval.cc only, right?

                                        // SConstruct: irt_compatible_rodata_addr
       kRegListReserved,                // read only register(s)
-      RegisterList(kRegisterStack));   // data addressing register(s)
+      kRegListDataAddr);               // data addressing register(s)
   bool success = false;
 
   vector<CodeSegment> segments;
   segments.push_back(CodeSegment(mbase, vbase, size));
 
   if (stubout_mode) {
     StuboutProblemSink sink;
     success = validator.Validate(segments, &sink);
   } else {
     EarlyExitProblemSink sink;
@@ skipping 77 matching lines @@
  */
 int NaClCopyInstruction(uint8_t *dst, uint8_t *src, uint8_t sz) {
   UNREFERENCED_PARAMETER(dst);
   UNREFERENCED_PARAMETER(src);
   UNREFERENCED_PARAMETER(sz);
 
   return 0;
 }
 
 EXTERN_C_END