[MIPS] Add thread-pointer to data addressing register list.

src/trusted/validator_mips/model.h

Index: src/trusted/validator_mips/model.h
diff --git a/src/trusted/validator_mips/model.h b/src/trusted/validator_mips/model.h
index fc709cb936b523b59bd080a9e8d0a1f7a64afd5d..b8bda206fdca9aa490de7892e94c8d9b01eb9da5 100644
--- a/src/trusted/validator_mips/model.h
+++ b/src/trusted/validator_mips/model.h
@@ -105,6 +105,10 @@ static const RegisterList kRegisterListEverything = RegisterList(-1);
 static uint32_t const kReservedRegsBitmask = kRegisterTls.Bitmask()
                                              + kRegisterJumpMask.Bitmask()
                                              + kRegisterLoadStoreMask.Bitmask();
+static uint32_t const kDataAddrRegsBitmask = kRegisterStack.Bitmask()
+                                             + kRegisterTls.Bitmask();
+
+static RegisterList const kRegListDataAddr = RegisterList(kDataAddrRegsBitmask);
 static RegisterList const kRegListReserved = RegisterList(kReservedRegsBitmask);

[Mark Seaborn, 2013/01/15 16:51:36]

Nit: Can you make the ordering of declarations consistent?

Either:

kReservedRegsBitmask
kRegListReserved

kDataAddrRegsBitmask
kRegListDataAddr

or

kReservedRegsBitmask
kDataAddrRegsBitmask

kRegListReserved
kRegListDataAddr


That said, using non-POD static constructors is against our coding style.  It
would be better not to introduce another non-POD usage here, and to move the
RegisterList() call into the use sites.  (Or can this be made non-POD by
inlining the constructor?  I'm not sure, but I don't think it can.)

[JF, 2013/01/15 17:03:03]

Agreed with Mark on non-POD, I made a similar change to the ARM code a while
ago.

[petarj, 2013/01/22 22:57:30]

Done.

[petarj, 2013/01/22 22:57:30]

Done (similar to the ARM change).

 
 /*