[MIPS] Add thread-pointer to data addressing register list.

src/trusted/validator_mips/model.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_MIPS_MODEL_H
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_MIPS_MODEL_H
 
 /*
@@ skipping 87 matching lines @@
 
 /*
  * A list containing every possible register, even some we don't define.
  * Used exclusively as a bogus scary return value for forbidden instructions.
  */
 static const RegisterList kRegisterListEverything = RegisterList(-1);
 
 static uint32_t const kReservedRegsBitmask = kRegisterTls.Bitmask()
                                              + kRegisterJumpMask.Bitmask()
                                              + kRegisterLoadStoreMask.Bitmask();
+static uint32_t const kDataAddrRegsBitmask = kRegisterStack.Bitmask()
+                                             + kRegisterTls.Bitmask();
+
+static RegisterList const kRegListDataAddr = RegisterList(kDataAddrRegsBitmask);
 static RegisterList const kRegListReserved = RegisterList(kReservedRegsBitmask);

[Mark Seaborn, 2013/01/15 16:51:36]

Nit: Can you make the ordering of declarations consistent?

Either:

kReservedRegsBitmask
kRegListReserved

kDataAddrRegsBitmask
kRegListDataAddr

or

kReservedRegsBitmask
kDataAddrRegsBitmask

kRegListReserved
kRegListDataAddr


That said, using non-POD static constructors is against our coding style.  It
would be better not to introduce another non-POD usage here, and to move the
RegisterList() call into the use sites.  (Or can this be made non-POD by
inlining the constructor?  I'm not sure, but I don't think it can.)

[JF, 2013/01/15 17:03:03]

Agreed with Mark on non-POD, I made a similar change to the ARM code a while
ago.

[petarj, 2013/01/22 22:57:30]

Done.

[petarj, 2013/01/22 22:57:30]

Done (similar to the ARM change).

 
 /*
  * A 32-bit Mips instruction of unspecified type.
  *
  * This class is designed for efficiency:
  *  - Its public methods for bitfield extraction are short and inline.
  *  - It has no vtable, so on 32-bit platforms it's exactly the size of the
  *    instruction it models.
  */
 class Instruction {
@@ skipping 35 matching lines @@
 
 // Opcode for nop instruction.
 uint32_t const kNop = 0x0;
 
 }  // namespace
 
 // Definitions for our inlined functions.
 #include "native_client/src/trusted/validator_mips/model-inl.h"
 
 #endif  // NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_MIPS_MODEL_H