|
Cleanup of SkyBinding, and resultant yak shaving.
Some files are moved by this:
Copy framework/node.dart into types/ - preparing for framework/'s decomissioning.
Move app/scheduler.dart into sky/scheduler.dart - "app" doesn't really make sense.
As part of the SkyBinding cleanup, I made the hit-testing less
RenderBox-specific, by having the HitTestEntry.target member be a
HitTestTarget, which is an interface with the handleEvent() function,
which is then implemented by RenderBox. In theory, someone could now
extend hit testing from the RenderBox world into their own tree of
nodes, and take part in all the same dispatch logic automatically.
This involved moving all the hit testing type definitions into a new
sky/hittest.dart file.
Renamed SkyBinding._app to SkyBinding._instance for clarity.
Moved code around in SkyBinding so that related things are together.
Made WidgetSkyBinding use the existing SkyBinding.instance singleton
logic rather than having its own copy.
I also added some stub README.md files that describe dependencies.
R=abarth@chromium.org
Committed: https://chromium.googlesource.com/external/mojo/+/8cc61a4ca15721f423369b5a4d6879cfaae97750
Note: in commit, types/, debug/ and sky/ all became base/.
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+107 lines, -153 lines) |
Patch |
 |
M |
sky/examples/game/lib/sprites.dart
|
View
|
1
2
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
sky/examples/rendering/spinning_flex.dart
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sky/examples/stocks2/lib/stock_app.dart
|
View
|
1
2
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/examples/widgets/sector.dart
|
View
|
1
2
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/examples/widgets/spinning_mixed.dart
|
View
|
1
2
|
2 chunks |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/BUILD.gn
|
View
|
1
|
1 chunk |
+4 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/animation/README.md
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/animation/generators.dart
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
sky/sdk/lib/app/scheduler.dart
|
View
|
|
1 chunk |
+0 lines, -60 lines |
0 comments
|
Download
|
 |
A |
sky/sdk/lib/base/README.md
|
View
|
1
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
sky/sdk/lib/base/debug.dart
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sky/sdk/lib/base/hit_test.dart
|
View
|
1
|
1 chunk |
+21 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
sky/sdk/lib/base/node.dart
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
sky/sdk/lib/base/scheduler.dart
|
View
|
1
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
 |
D |
sky/sdk/lib/debug/utils.dart
|
View
|
1
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/editing2/input.dart
|
View
|
1
2
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/animation/generators.dart
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/embedder.dart
|
View
|
1
2
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/framework/shell.dart
|
View
|
1
2
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
A |
sky/sdk/lib/rendering/README.md
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/rendering/box.dart
|
View
|
1
|
2 chunks |
+2 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/rendering/object.dart
|
View
|
1
|
3 chunks |
+6 lines, -17 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/rendering/sky_binding.dart
|
View
|
1
|
4 chunks |
+23 lines, -24 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/widgets/basic.dart
|
View
|
1
2
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/widgets/menu_item.dart
|
View
|
1
2
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sky/sdk/lib/widgets/widget.dart
|
View
|
1
2
|
4 chunks |
+11 lines, -13 lines |
0 comments
|
Download
|
Total messages: 3 (1 generated)
|