Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: sky/sdk/lib/widgets/basic.dart

Issue 1187393002: Cleanup of SkyBinding, and resultant yak shaving. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/sdk/lib/rendering/sky_binding.dart ('k') | sky/sdk/lib/widgets/menu_item.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 6
7 import 'package:vector_math/vector_math.dart'; 7 import 'package:vector_math/vector_math.dart';
8 8
9 import '../painting/text_style.dart'; 9 import '../painting/text_style.dart';
10 import '../rendering/block.dart'; 10 import '../rendering/block.dart';
(...skipping 418 matching lines...) Expand 10 before | Expand all | Expand 10 after
429 429
430 void syncRenderObject(Widget old) { 430 void syncRenderObject(Widget old) {
431 super.syncRenderObject(old); 431 super.syncRenderObject(old);
432 if (old != null) { 432 if (old != null) {
433 assert(old is WidgetToRenderBoxAdapter); 433 assert(old is WidgetToRenderBoxAdapter);
434 assert(root == old.root); 434 assert(root == old.root);
435 } 435 }
436 } 436 }
437 437
438 void remove() { 438 void remove() {
439 parent.detachChildRoot(this); 439 RenderObjectWrapper ancestor = findAncestor(RenderObjectWrapper);
440 assert(ancestor is RenderObjectWrapper);
441 ancestor.detachChildRoot(this);
440 super.remove(); 442 super.remove();
441 } 443 }
442 444
443 } 445 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/rendering/sky_binding.dart ('k') | sky/sdk/lib/widgets/menu_item.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698