sky/sdk/lib/widgets/basic.dart - Issue 1187393002: Cleanup of SkyBinding, and resultant yak shaving.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/sdk/lib/widgets/basic.dart

Issue 1187393002: Cleanup of SkyBinding, and resultant yak shaving. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/sdk/lib/widgets/basic.dart

diff --git a/sky/sdk/lib/widgets/basic.dart b/sky/sdk/lib/widgets/basic.dart

index 4ca534acdb93340e4e3114653246eafcb014acbf..038fec516c3f39cb998fb6221e66ed9396ac4d7b 100644

--- a/sky/sdk/lib/widgets/basic.dart

+++ b/sky/sdk/lib/widgets/basic.dart

@@ -436,7 +436,9 @@ class WidgetToRenderBoxAdapter extends LeafRenderObjectWrapper {

}

void remove() {

- parent.detachChildRoot(this);

+ RenderObjectWrapper ancestor = findAncestor(RenderObjectWrapper);

+ assert(ancestor is RenderObjectWrapper);

+ ancestor.detachChildRoot(this);

super.remove();

}

« no previous file with comments | « sky/sdk/lib/rendering/sky_binding.dart ('k') | sky/sdk/lib/widgets/menu_item.dart » ('j') | no next file with comments »