Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1186713010: Subzero: Add more kinds of RMW lowering. (Closed)

Created:
5 years, 6 months ago by Jim Stichnoth
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add more kinds of RMW lowering. Specifically: sub, and, or, xor; for all integer types. Turns out that RMW is not possible for fadd/fsub/fmul/fdiv as well as operations on vector types, because the corresponding x86 instructions require the result to be in a physical register. Refactors the assembler's implementations of add/or/adc/sbb/and/sub/xor/cmp to avoid repetition. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4095 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=cac003e8f33c970e233e4f9194930b7869f0b65a

Patch Set 1 #

Patch Set 2 : Refactor the assembler for 8 integer arithmetic instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -225 lines) Patch
M src/IceAssemblerX8632.h View 1 3 chunks +30 lines, -0 lines 0 comments Download
M src/IceAssemblerX8632.cpp View 1 2 chunks +125 lines, -200 lines 0 comments Download
M src/IceELFObjectWriter.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/IceInstX8632.h View 6 chunks +13 lines, -1 line 0 comments Download
M src/IceInstX8632.cpp View 2 chunks +24 lines, -0 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 6 chunks +18 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 4 chunks +59 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
5 years, 6 months ago (2015-06-18 17:37:27 UTC) #2
jvoung (off chromium)
lgtm
5 years, 6 months ago (2015-06-18 18:30:11 UTC) #3
Jim Stichnoth
5 years, 6 months ago (2015-06-18 19:49:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cac003e8f33c970e233e4f9194930b7869f0b65a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698