Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: src/trusted/validator/x86/validate_x86.gyp

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator/x86/validate_x86.gyp
diff --git a/src/trusted/validator/x86/validate_x86.gyp b/src/trusted/validator/x86/validate_x86.gyp
index f12f4e6aabdaac6fbed0bdb4d59201380d92902a..bfdacc0fbb0bc48ba37499f8257375c794929e63 100644
--- a/src/trusted/validator/x86/validate_x86.gyp
+++ b/src/trusted/validator/x86/validate_x86.gyp
@@ -19,8 +19,6 @@
'sources': [
'error_reporter.c',
'halt_trim.c',
- 'nacl_cpuid.c',
- 'nacl_xgetbv.S',
'ncinstbuffer.c',
'x86_insts.c',
'nc_segment.c',
@@ -72,6 +70,7 @@
},
'dependencies': [
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform',
+ '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cpu_features',
],
},
{ 'target_name': 'ncval_base_verbose_x86_32',
@@ -95,6 +94,7 @@
},
'dependencies': [
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform64',
+ '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cpu_features64',
],
},
{ 'target_name': 'ncval_base_verbose_x86_64',
@@ -118,6 +118,7 @@
},
'dependencies': [
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform',
+ '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cpu_features',
],
},
{ 'target_name': 'ncval_base_verbose_x86_64',
« no previous file with comments | « src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h ('k') | src/trusted/validator_arm/build.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698