Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: src/trusted/validator/x86/validate_x86.gyp

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # Copyright (c) 2011 The Native Client Authors. All rights reserved. 1 # Copyright (c) 2011 The Native Client Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Build the specific library dependencies for validating x86 code, used 5 # Build the specific library dependencies for validating x86 code, used
6 # by both the x86-32 and x86-64 validators. 6 # by both the x86-32 and x86-64 validators.
7 # Note: Would like to name this file validator_x86.gyp, but that name is 7 # Note: Would like to name this file validator_x86.gyp, but that name is
8 # already used, and on mac's, this is not allowed. 8 # already used, and on mac's, this is not allowed.
9 { 9 {
10 'includes': [ 10 'includes': [
11 '../../../../build/common.gypi', 11 '../../../../build/common.gypi',
12 ], 12 ],
13 'target_defaults': { 13 'target_defaults': {
14 'variables': { 14 'variables': {
15 'target_base': 'none', 15 'target_base': 'none',
16 }, 16 },
17 'target_conditions': [ 17 'target_conditions': [
18 ['target_base=="ncval_base"', { 18 ['target_base=="ncval_base"', {
19 'sources': [ 19 'sources': [
20 'error_reporter.c', 20 'error_reporter.c',
21 'halt_trim.c', 21 'halt_trim.c',
22 'nacl_cpuid.c',
23 'nacl_xgetbv.S',
24 'ncinstbuffer.c', 22 'ncinstbuffer.c',
25 'x86_insts.c', 23 'x86_insts.c',
26 'nc_segment.c', 24 'nc_segment.c',
27 ], 25 ],
28 'cflags!': [ 26 'cflags!': [
29 '-Wextra', 27 '-Wextra',
30 '-Wswitch-enum', 28 '-Wswitch-enum',
31 '-Wsign-compare' 29 '-Wsign-compare'
32 ], 30 ],
33 # VS2010 does not correctly incrementally link obj files generated 31 # VS2010 does not correctly incrementally link obj files generated
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 'conditions': [ 63 'conditions': [
66 ['target_arch=="ia32"', { 64 ['target_arch=="ia32"', {
67 'targets': [ 65 'targets': [
68 { 'target_name': 'ncval_base_x86_32', 66 { 'target_name': 'ncval_base_x86_32',
69 'type': 'static_library', 67 'type': 'static_library',
70 'variables': { 68 'variables': {
71 'target_base': 'ncval_base', 69 'target_base': 'ncval_base',
72 }, 70 },
73 'dependencies': [ 71 'dependencies': [
74 '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform', 72 '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform',
73 '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cp u_features',
75 ], 74 ],
76 }, 75 },
77 { 'target_name': 'ncval_base_verbose_x86_32', 76 { 'target_name': 'ncval_base_verbose_x86_32',
78 'type': 'static_library', 77 'type': 'static_library',
79 'variables': { 78 'variables': {
80 'target_base': 'ncval_base_verbose', 79 'target_base': 'ncval_base_verbose',
81 }, 80 },
82 'dependencies': [ 81 'dependencies': [
83 'ncval_base_x86_32', 82 'ncval_base_x86_32',
84 ], 83 ],
85 }, 84 },
86 ], 85 ],
87 }], 86 }],
88 ['OS=="win"', { 87 ['OS=="win"', {
89 'targets': [ 88 'targets': [
90 { 'target_name': 'ncval_base_x86_64', 89 { 'target_name': 'ncval_base_x86_64',
91 'type': 'static_library', 90 'type': 'static_library',
92 'variables': { 91 'variables': {
93 'target_base': 'ncval_base', 92 'target_base': 'ncval_base',
94 'win_target': 'x64', 93 'win_target': 'x64',
95 }, 94 },
96 'dependencies': [ 95 'dependencies': [
97 '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform64' , 96 '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform64' ,
97 '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cp u_features64',
98 ], 98 ],
99 }, 99 },
100 { 'target_name': 'ncval_base_verbose_x86_64', 100 { 'target_name': 'ncval_base_verbose_x86_64',
101 'type': 'static_library', 101 'type': 'static_library',
102 'variables': { 102 'variables': {
103 'target_base': 'ncval_base_verbose', 103 'target_base': 'ncval_base_verbose',
104 'win_target': 'x64', 104 'win_target': 'x64',
105 'dependencies': [ 105 'dependencies': [
106 'ncval_base_x86_64', 106 'ncval_base_x86_64',
107 ], 107 ],
108 }, 108 },
109 }, 109 },
110 ], 110 ],
111 }], 111 }],
112 ['OS!="win" and target_arch=="x64"', { 112 ['OS!="win" and target_arch=="x64"', {
113 'targets': [ 113 'targets': [
114 { 'target_name': 'ncval_base_x86_64', 114 { 'target_name': 'ncval_base_x86_64',
115 'type': 'static_library', 115 'type': 'static_library',
116 'variables': { 116 'variables': {
117 'target_base': 'ncval_base', 117 'target_base': 'ncval_base',
118 }, 118 },
119 'dependencies': [ 119 'dependencies': [
120 '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform', 120 '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform',
121 '<(DEPTH)/native_client/src/trusted/cpu_features/cpu_features.gyp:cp u_features',
121 ], 122 ],
122 }, 123 },
123 { 'target_name': 'ncval_base_verbose_x86_64', 124 { 'target_name': 'ncval_base_verbose_x86_64',
124 'type': 'static_library', 125 'type': 'static_library',
125 'variables': { 126 'variables': {
126 'target_base': 'ncval_base_verbose', 127 'target_base': 'ncval_base_verbose',
127 }, 128 },
128 'dependencies': [ 129 'dependencies': [
129 'ncval_base_x86_64', 130 'ncval_base_x86_64',
130 ], 131 ],
131 }, 132 },
132 ], 133 ],
133 }], 134 }],
134 [ 'target_arch=="arm"', { 135 [ 'target_arch=="arm"', {
135 'targets': [] 136 'targets': []
136 }], 137 }],
137 ], 138 ],
138 } 139 }
OLDNEW
« no previous file with comments | « src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h ('k') | src/trusted/validator_arm/build.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698