src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h - Issue 11864002: Move CPU features into its own static library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h

Issue 11864002: Move CPU features into its own static library. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client

Patch Set: Address bsy's comments by not building x86 target when host isn't x86. This is how things are curre… Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h

diff --git a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h

index 2090f50267982641bf04668d24afea41a7d79533..40bc2374d516d36ee3822f5811a42ed65cc89cac 100644

--- a/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h

+++ b/src/trusted/validator/x86/ncval_seg_sfi/ncvalidate_internaltypes.h

@@ -13,7 +13,7 @@

* that define the validator.

-#include "native_client/src/trusted/validator/x86/nacl_cpuid.h"

+#include "native_client/src/trusted/cpu_features/arch/x86/cpu_x86.h"

#include "native_client/src/trusted/validator/x86/ncval_seg_sfi/ncdecode.h"

/* statistics */

@@ -61,7 +61,7 @@ typedef struct NCValidatorState {

NCDecoderState dstate;

NCDecoderInst inst_buffer[kNCValidatorInstBufferSize];

- NaClCPUFeaturesX86 cpufeatures; /* from CPUID bit masks; see nacl_cpuid.c */

+ NaClCPUFeaturesX86 cpufeatures; /* from CPUID bit masks; see cpu_x86.c */

NaClPcAddress iadrbase;

NaClMemorySize codesize;

uint8_t bundle_size;