Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1186033006: [turbofan] Introduce DeadValue and DeadEffect operators. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce DeadValue and DeadEffect operators. R=bmeurer@chromium.org Committed: https://crrev.com/eb0e7437d30e7be553b4248ea0a4c2f637f4211c Cr-Commit-Position: refs/heads/master@{#29104}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Total comments: 4

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -45 lines) Patch
M src/compiler/ast-graph-builder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M src/compiler/common-operator.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/control-reducer.cc View 1 2 5 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-graph.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/js-graph.cc View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/js-inlining.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/loop-peeling.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 2 4 chunks +6 lines, -3 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/typer.cc View 1 2 5 chunks +13 lines, -2 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/compiler/test-control-reducer.cc View 1 2 3 chunks +8 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/graph-trimmer-unittest.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-18 06:57:27 UTC) #1
Benedikt Meurer
LGTM once nits are addressed. Thanks! https://codereview.chromium.org/1186033006/diff/20001/src/compiler/opcodes.h File src/compiler/opcodes.h (right): https://codereview.chromium.org/1186033006/diff/20001/src/compiler/opcodes.h#newcode13 src/compiler/opcodes.h:13: V(Dead) \ Nit: ...
5 years, 6 months ago (2015-06-18 07:16:53 UTC) #3
Michael Starzinger
https://codereview.chromium.org/1186033006/diff/20001/src/compiler/opcodes.h File src/compiler/opcodes.h (right): https://codereview.chromium.org/1186033006/diff/20001/src/compiler/opcodes.h#newcode13 src/compiler/opcodes.h:13: V(Dead) \ On 2015/06/18 07:16:53, Benedikt Meurer wrote: > ...
5 years, 6 months ago (2015-06-18 07:49:28 UTC) #4
Jarin
lgtm
5 years, 6 months ago (2015-06-18 08:07:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186033006/40001
5 years, 6 months ago (2015-06-18 08:15:39 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-18 08:17:14 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-18 08:17:25 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/eb0e7437d30e7be553b4248ea0a4c2f637f4211c
Cr-Commit-Position: refs/heads/master@{#29104}

Powered by Google App Engine
This is Rietveld 408576698