Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: test/cctest/compiler/test-control-reducer.cc

Issue 1186033006: [turbofan] Introduce DeadValue and DeadEffect operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/verifier.cc ('k') | test/cctest/compiler/test-loop-analysis.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-control-reducer.cc
diff --git a/test/cctest/compiler/test-control-reducer.cc b/test/cctest/compiler/test-control-reducer.cc
index e34dc9a2045f4a7dfa10c4ac2ee19263dae3c771..2f0cb17172d1cbb5b9ebb0cecc33f9a9e49f4ca5 100644
--- a/test/cctest/compiler/test-control-reducer.cc
+++ b/test/cctest/compiler/test-control-reducer.cc
@@ -75,7 +75,7 @@ class ControlReducerTester : HandleAndZoneScope {
one(jsgraph.OneConstant()),
half(jsgraph.Constant(0.5)),
self(graph.NewNode(common.Int32Constant(0xaabbccdd))),
- dead(graph.NewNode(common.Dead())) {
+ dead(graph.NewNode(common.DeadControl())) {
graph.SetEnd(end);
graph.SetStart(start);
leaf[0] = zero;
@@ -185,12 +185,16 @@ class ControlReducerTester : HandleAndZoneScope {
if (use->opcode() == IrOpcode::kIfTrue) {
Node* result = ControlReducer::ReduceIfNodeForTesting(&jsgraph, use);
if (expected == kTrue) CHECK_EQ(control, result);
- if (expected == kFalse) CHECK_EQ(IrOpcode::kDead, result->opcode());
+ if (expected == kFalse) {
+ CHECK_EQ(IrOpcode::kDeadControl, result->opcode());
+ }
if (expected == kUnknown) CHECK_EQ(use, result);
} else if (use->opcode() == IrOpcode::kIfFalse) {
Node* result = ControlReducer::ReduceIfNodeForTesting(&jsgraph, use);
if (expected == kFalse) CHECK_EQ(control, result);
- if (expected == kTrue) CHECK_EQ(IrOpcode::kDead, result->opcode());
+ if (expected == kTrue) {
+ CHECK_EQ(IrOpcode::kDeadControl, result->opcode());
+ }
if (expected == kUnknown) CHECK_EQ(use, result);
} else {
UNREACHABLE();
@@ -793,7 +797,7 @@ TEST(CMergeReduce_exhaustive_4) {
int count = selector.count;
if (count == 0) {
// result should be dead.
- CHECK_EQ(IrOpcode::kDead, result->opcode());
+ CHECK_EQ(IrOpcode::kDeadControl, result->opcode());
} else if (count == 1) {
// merge should be replaced with one of the controls.
CHECK_EQ(controls[selector.single_index()], result);
« no previous file with comments | « src/compiler/verifier.cc ('k') | test/cctest/compiler/test-loop-analysis.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698