Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Side by Side Diff: src/compiler/verifier.cc

Issue 1186033006: [turbofan] Introduce DeadValue and DeadEffect operators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-control-reducer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 CheckUpperIs(node, Type::Internal()); 185 CheckUpperIs(node, Type::Internal());
186 break; 186 break;
187 case IrOpcode::kEnd: 187 case IrOpcode::kEnd:
188 // End has no outputs. 188 // End has no outputs.
189 CHECK(node->op()->ValueOutputCount() == 0); 189 CHECK(node->op()->ValueOutputCount() == 0);
190 CHECK(node->op()->EffectOutputCount() == 0); 190 CHECK(node->op()->EffectOutputCount() == 0);
191 CHECK(node->op()->ControlOutputCount() == 0); 191 CHECK(node->op()->ControlOutputCount() == 0);
192 // Type is empty. 192 // Type is empty.
193 CheckNotTyped(node); 193 CheckNotTyped(node);
194 break; 194 break;
195 case IrOpcode::kDead: 195 case IrOpcode::kDeadValue:
196 case IrOpcode::kDeadEffect:
197 case IrOpcode::kDeadControl:
196 // Dead is never connected to the graph. 198 // Dead is never connected to the graph.
197 // TODO(mstarzinger): Make the GraphReducer immediately perform control 199 // TODO(mstarzinger): Make the GraphReducer immediately perform control
198 // reduction in case control is killed. This will prevent {Dead} from 200 // reduction in case control is killed. This will prevent {Dead} from
199 // being reachable after a phase finished. Then re-enable below assert. 201 // being reachable after a phase finished. Then re-enable below assert.
200 // UNREACHABLE(); 202 // UNREACHABLE();
201 break; 203 break;
202 case IrOpcode::kBranch: { 204 case IrOpcode::kBranch: {
203 // Branch uses are IfTrue and IfFalse. 205 // Branch uses are IfTrue and IfFalse.
204 int count_true = 0, count_false = 0; 206 int count_true = 0, count_false = 0;
205 for (auto use : node->uses()) { 207 for (auto use : node->uses()) {
(...skipping 925 matching lines...) Expand 10 before | Expand all | Expand 10 after
1131 // Check inputs for all nodes in the block. 1133 // Check inputs for all nodes in the block.
1132 for (size_t i = 0; i < block->NodeCount(); i++) { 1134 for (size_t i = 0; i < block->NodeCount(); i++) {
1133 Node* node = block->NodeAt(i); 1135 Node* node = block->NodeAt(i);
1134 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1); 1136 CheckInputsDominate(schedule, block, node, static_cast<int>(i) - 1);
1135 } 1137 }
1136 } 1138 }
1137 } 1139 }
1138 } // namespace compiler 1140 } // namespace compiler
1139 } // namespace internal 1141 } // namespace internal
1140 } // namespace v8 1142 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/typer.cc ('k') | test/cctest/compiler/test-control-reducer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698