Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1185703002: Fix clobbered register when setting this_function variable. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix clobbered register when setting this_function variable. R=arv@chromium.org TEST=mjsunit/regress/regress-crbug-498022 BUG=chromium:498022 LOG=N Committed: https://crrev.com/bf2bbc8ba508ccd21edf3c08d2e4192c4764ae91 Cr-Commit-Position: refs/heads/master@{#29020}

Patch Set 1 #

Patch Set 2 : Fix ARM64 compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/full-codegen-ppc.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-498022.js View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-12 14:43:41 UTC) #1
rossberg
lgtm
5 years, 6 months ago (2015-06-15 09:43:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185703002/20001
5 years, 6 months ago (2015-06-15 09:44:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-15 10:18:50 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/bf2bbc8ba508ccd21edf3c08d2e4192c4764ae91 Cr-Commit-Position: refs/heads/master@{#29020}
5 years, 6 months ago (2015-06-15 10:19:05 UTC) #7
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1184093003/ by machenbach@chromium.org. ...
5 years, 6 months ago (2015-06-15 11:55:48 UTC) #8
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-15 16:37:43 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698