Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 1185703002: Fix clobbered register when setting this_function variable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix ARM64 compilation. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after
236 } 236 }
237 } 237 }
238 } 238 }
239 } 239 }
240 240
241 // Possibly set up a local binding to the this function which is used in 241 // Possibly set up a local binding to the this function which is used in
242 // derived constructors with super calls. 242 // derived constructors with super calls.
243 Variable* this_function_var = scope()->this_function_var(); 243 Variable* this_function_var = scope()->this_function_var();
244 if (this_function_var != nullptr) { 244 if (this_function_var != nullptr) {
245 Comment cmnt(masm_, "[ This function"); 245 Comment cmnt(masm_, "[ This function");
246 if (!function_in_register) {
247 __ ldr(r1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
248 function_in_register = true;
249 }
246 SetVar(this_function_var, r1, r0, r2); 250 SetVar(this_function_var, r1, r0, r2);
247 } 251 }
248 252
249 Variable* new_target_var = scope()->new_target_var(); 253 Variable* new_target_var = scope()->new_target_var();
250 if (new_target_var != nullptr) { 254 if (new_target_var != nullptr) {
251 Comment cmnt(masm_, "[ new.target"); 255 Comment cmnt(masm_, "[ new.target");
252 // new.target is parameter -2. 256 // new.target is parameter -2.
253 int offset = 2 * kPointerSize + 257 int offset = 2 * kPointerSize +
254 (info_->scope()->num_parameters() + 1) * kPointerSize; 258 (info_->scope()->num_parameters() + 1) * kPointerSize;
255 __ ldr(r0, MemOperand(fp, offset)); 259 __ ldr(r0, MemOperand(fp, offset));
(...skipping 5338 matching lines...) Expand 10 before | Expand all | Expand 10 after
5594 DCHECK(interrupt_address == 5598 DCHECK(interrupt_address ==
5595 isolate->builtins()->OsrAfterStackCheck()->entry()); 5599 isolate->builtins()->OsrAfterStackCheck()->entry());
5596 return OSR_AFTER_STACK_CHECK; 5600 return OSR_AFTER_STACK_CHECK;
5597 } 5601 }
5598 5602
5599 5603
5600 } // namespace internal 5604 } // namespace internal
5601 } // namespace v8 5605 } // namespace v8
5602 5606
5603 #endif // V8_TARGET_ARCH_ARM 5607 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/full-codegen-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698