Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: src/mips64/full-codegen-mips64.cc

Issue 1185703002: Fix clobbered register when setting this_function variable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix ARM64 compilation. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 231 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 } 242 }
243 } 243 }
244 } 244 }
245 } 245 }
246 246
247 // Possibly set up a local binding to the this function which is used in 247 // Possibly set up a local binding to the this function which is used in
248 // derived constructors with super calls. 248 // derived constructors with super calls.
249 Variable* this_function_var = scope()->this_function_var(); 249 Variable* this_function_var = scope()->this_function_var();
250 if (this_function_var != nullptr) { 250 if (this_function_var != nullptr) {
251 Comment cmnt(masm_, "[ This function"); 251 Comment cmnt(masm_, "[ This function");
252 if (!function_in_register) {
253 __ ld(a1, MemOperand(fp, JavaScriptFrameConstants::kFunctionOffset));
254 function_in_register = true;
255 }
252 SetVar(this_function_var, a1, a2, a3); 256 SetVar(this_function_var, a1, a2, a3);
253 } 257 }
254 258
255 Variable* new_target_var = scope()->new_target_var(); 259 Variable* new_target_var = scope()->new_target_var();
256 if (new_target_var != nullptr) { 260 if (new_target_var != nullptr) {
257 Comment cmnt(masm_, "[ new.target"); 261 Comment cmnt(masm_, "[ new.target");
258 // new.target is parameter -2. 262 // new.target is parameter -2.
259 int offset = 2 * kPointerSize + 263 int offset = 2 * kPointerSize +
260 (info_->scope()->num_parameters() + 1) * kPointerSize; 264 (info_->scope()->num_parameters() + 1) * kPointerSize;
261 __ ld(v0, MemOperand(fp, offset)); 265 __ ld(v0, MemOperand(fp, offset));
(...skipping 5283 matching lines...) Expand 10 before | Expand all | Expand 10 after
5545 reinterpret_cast<uint64_t>( 5549 reinterpret_cast<uint64_t>(
5546 isolate->builtins()->OsrAfterStackCheck()->entry())); 5550 isolate->builtins()->OsrAfterStackCheck()->entry()));
5547 return OSR_AFTER_STACK_CHECK; 5551 return OSR_AFTER_STACK_CHECK;
5548 } 5552 }
5549 5553
5550 5554
5551 } // namespace internal 5555 } // namespace internal
5552 } // namespace v8 5556 } // namespace v8
5553 5557
5554 #endif // V8_TARGET_ARCH_MIPS64 5558 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/mips/full-codegen-mips.cc ('k') | src/ppc/full-codegen-ppc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698