scripts/slave/recipes/bisect.py - Issue 1185693002: Move builders.py and steps.py to chromium_tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisect.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Address review comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/bisect.py

diff --git a/scripts/slave/recipes/bisect.py b/scripts/slave/recipes/bisect.py

index fc595ad61ee2d32ab5915d93721894322c85a9bb..9ea252bbd8d199416cd2e8ab07ef86a7b311a796 100644

--- a/scripts/slave/recipes/bisect.py

+++ b/scripts/slave/recipes/bisect.py

@@ -234,6 +234,8 @@ def _get_step_data_for_revision(api, revision_data, broken_cp=None,

def _ensure_checkout(api):

mastername = api.properties.get('mastername')

buildername = api.properties.get('buildername')

+ # TODO(akuegel): Explicitly load the configs for the builders and don't rely

+ # on builders.py in chromium_tests recipe module.

api.chromium_tests.configure_build(mastername, buildername)

api.chromium_tests.prepare_checkout(mastername, buildername)

« no previous file with comments | « scripts/slave/recipes/android/perf.py ('k') | scripts/slave/recipes/bisection/desktop_bisect.py » ('j') | no next file with comments »