Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: scripts/slave/recipes/bisect.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Address review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import base64 5 import base64
6 import collections 6 import collections
7 import json 7 import json
8 8
9 DEPS = [ 9 DEPS = [
10 'auto_bisect', 10 'auto_bisect',
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 227
228 if 'cl_info' in revision_data: 228 if 'cl_info' in revision_data:
229 step_name = 'Reading culprit cl information.' 229 step_name = 'Reading culprit cl information.'
230 stdout = api.raw_io.output(revision_data['cl_info']) 230 stdout = api.raw_io.output(revision_data['cl_info'])
231 yield api.step_data(step_name, stdout=stdout) 231 yield api.step_data(step_name, stdout=stdout)
232 232
233 233
234 def _ensure_checkout(api): 234 def _ensure_checkout(api):
235 mastername = api.properties.get('mastername') 235 mastername = api.properties.get('mastername')
236 buildername = api.properties.get('buildername') 236 buildername = api.properties.get('buildername')
237 # TODO(akuegel): Explicitly load the configs for the builders and don't rely
238 # on builders.py in chromium_tests recipe module.
237 api.chromium_tests.configure_build(mastername, buildername) 239 api.chromium_tests.configure_build(mastername, buildername)
238 api.chromium_tests.prepare_checkout(mastername, buildername) 240 api.chromium_tests.prepare_checkout(mastername, buildername)
239 241
240 242
241 def _gather_reference_range(api, bisector): 243 def _gather_reference_range(api, bisector):
242 bisector.good_rev.start_job() 244 bisector.good_rev.start_job()
243 bisector.bad_rev.start_job() 245 bisector.bad_rev.start_job()
244 bisector.wait_for_all([bisector.good_rev, bisector.bad_rev]) 246 bisector.wait_for_all([bisector.good_rev, bisector.bad_rev])
245 if bisector.good_rev.failed: 247 if bisector.good_rev.failed:
246 api.halt('Testing the "good" revision failed') 248 api.halt('Testing the "good" revision failed')
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 If such revision completes the bisect process it sets the flag so that the 281 If such revision completes the bisect process it sets the flag so that the
280 main loop stops. 282 main loop stops.
281 """ 283 """
282 while revisions_to_check: 284 while revisions_to_check:
283 completed_revision = bisector.wait_for_any(revisions_to_check) 285 completed_revision = bisector.wait_for_any(revisions_to_check)
284 revisions_to_check.remove(completed_revision) 286 revisions_to_check.remove(completed_revision)
285 if not completed_revision.aborted: 287 if not completed_revision.aborted:
286 if bisector.check_bisect_finished(completed_revision): 288 if bisector.check_bisect_finished(completed_revision):
287 bisector.bisect_over = True 289 bisector.bisect_over = True
288 bisector.abort_unnecessary_jobs() 290 bisector.abort_unnecessary_jobs()
OLDNEW
« no previous file with comments | « scripts/slave/recipes/android/perf.py ('k') | scripts/slave/recipes/bisection/desktop_bisect.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698