Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: scripts/slave/recipes/android/perf.py

Issue 1185693002: Move builders.py and steps.py to chromium_tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Address review comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/gpu/api.py ('k') | scripts/slave/recipes/bisect.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/android/perf.py
diff --git a/scripts/slave/recipes/android/perf.py b/scripts/slave/recipes/android/perf.py
index 365b87159259ea6a7c018300605829cb087c45f1..d009111c41d395a11a472e3827777a83c8917a02 100644
--- a/scripts/slave/recipes/android/perf.py
+++ b/scripts/slave/recipes/android/perf.py
@@ -103,6 +103,8 @@ BUILDERS = freeze({
def GenSteps(api):
mastername = api.properties['mastername']
buildername = api.properties['buildername']
+ # TODO(akuegel): Move the configs in builders.py in chromium_tests to this
+ # recipe, and get rid of duplications.
builder = thaw(BUILDERS[mastername][buildername])
api.chromium_android.set_config(
builder.get('recipe_config', 'base_config'), REPO_NAME='src',
@@ -135,11 +137,11 @@ def GenSteps(api):
test_spec = api.chromium_tests.read_test_spec(api, test_spec_file)
scripts_compile_targets = \
- api.chromium.get_compile_targets_for_scripts().json.output
+ api.chromium_tests.get_compile_targets_for_scripts().json.output
builder['tests'] = api.chromium_tests.generate_tests_from_test_spec(
api, test_spec, builder, buildername, mastername, False,
- scripts_compile_targets, [api.chromium.steps.generate_script])
+ scripts_compile_targets, [api.chromium_tests.steps.generate_script])
api.path['checkout'] = api.path['slave_build'].join('src')
api.chromium_android.clean_local_files()
« no previous file with comments | « scripts/slave/recipe_modules/gpu/api.py ('k') | scripts/slave/recipes/bisect.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698