Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1185573003: Import new functionality for GL4 backend (Closed)

Created:
5 years, 6 months ago by Chris Dalton
Modified:
5 years, 6 months ago
Reviewers:
bsalomon, caryclark
CC:
reviews_skia.org, joshualitt
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Import functionality for new GL backend Brings in the following functionality: ARB_draw_instanced ARB_instanced_arrays NV_bindless_texture EXT_direct_state_access KHR_debug Also cleans up some of the NVPR extension loading. BUG=skia: Committed: https://skia.googlesource.com/skia/+/202c4c75fb806f751cf796850bf67fe9793e0643 Committed: https://skia.googlesource.com/skia/+/626e1ffe84c24a969dc56ca70ab2e950bf5034c4

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix dsa interaction with instanced draw #

Patch Set 4 : fix KHR_debug suffixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+963 lines, -219 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 2 2 chunks +340 lines, -197 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 2 3 chunks +142 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 2 3 4 chunks +181 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 2 4 chunks +15 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 7 chunks +33 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCreateNullInterface.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +39 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 3 chunks +173 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.h View 3 chunks +13 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLNoOpInterface.cpp View 3 chunks +16 lines, -0 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M src/gpu/gl/debug/GrGLCreateDebugInterface.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/GrDrawTargetTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Chris Dalton
5 years, 6 months ago (2015-06-12 04:51:06 UTC) #2
bsalomon
lgtm
5 years, 6 months ago (2015-06-12 16:11:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185573003/20001
5 years, 6 months ago (2015-06-12 17:25:58 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/202c4c75fb806f751cf796850bf67fe9793e0643
5 years, 6 months ago (2015-06-12 17:31:41 UTC) #6
djsollen
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1184863002/ by djsollen@google.com. ...
5 years, 6 months ago (2015-06-12 19:00:50 UTC) #7
Chris Dalton
5 years, 6 months ago (2015-06-12 20:17:45 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185573003/60001
5 years, 6 months ago (2015-06-12 20:42:35 UTC) #12
bsalomon
lgtm
5 years, 6 months ago (2015-06-12 20:44:24 UTC) #13
bsalomon
lgtm lgtm
5 years, 6 months ago (2015-06-12 20:44:24 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-12 20:53:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1185573003/60001
5 years, 6 months ago (2015-06-12 20:55:59 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 20:56:55 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/626e1ffe84c24a969dc56ca70ab2e950bf5034c4

Powered by Google App Engine
This is Rietveld 408576698