Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1185563003: Move AuthenticatingURLLoader app from ErrorHandler to callbacks (Closed)

Created:
5 years, 6 months ago by blundell
Modified:
5 years, 6 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move AuthenticatingURLLoader app from ErrorHandler to callbacks \o/ R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/89cb670f0731680f0e3cb98f3845a4a2c2c65bd9

Patch Set 1 #

Patch Set 2 : Self-review #

Patch Set 3 : Response to review #

Messages

Total messages: 5 (1 generated)
blundell
5 years, 6 months ago (2015-06-12 08:52:58 UTC) #2
qsr
LGTM with transforming the last closure in a base::Bind to not have the rzw pointer,
5 years, 6 months ago (2015-06-12 09:11:02 UTC) #3
blundell
Done.
5 years, 6 months ago (2015-06-12 09:19:47 UTC) #4
blundell
5 years, 6 months ago (2015-06-12 09:24:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
89cb670f0731680f0e3cb98f3845a4a2c2c65bd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698