Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h

Issue 1185563003: Move AuthenticatingURLLoader app from ErrorHandler to callbacks (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Response to review Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h
diff --git a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h
index 628a34d7b270ed73e05acf3f3eebf29c2e95ee11..933d63ae8db549846c9274bf4a1b156560bb26e9 100644
--- a/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h
+++ b/services/authenticating_url_loader_interceptor/authenticating_url_loader_interceptor_factory.h
@@ -8,7 +8,6 @@
#include <memory>
#include "base/callback.h"
-#include "mojo/public/cpp/bindings/error_handler.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
#include "mojo/services/authentication/public/interfaces/authentication.mojom.h"
@@ -22,8 +21,7 @@ class ApplicationImpl;
class AuthenticatingURLLoaderInterceptor;
class AuthenticatingURLLoaderInterceptorFactory
- : public URLLoaderInterceptorFactory,
- public ErrorHandler {
+ : public URLLoaderInterceptorFactory {
public:
AuthenticatingURLLoaderInterceptorFactory(
mojo::InterfaceRequest<URLLoaderInterceptorFactory> request,
@@ -41,15 +39,14 @@ class AuthenticatingURLLoaderInterceptorFactory
void RetrieveToken(const GURL& url,
const base::Callback<void(std::string)>& callback);
- void OnInterceptorError(AuthenticatingURLLoaderInterceptor* interceptor);
-
private:
// URLLoaderInterceptorFactory:
void Create(
mojo::InterfaceRequest<URLLoaderInterceptor> interceptor) override;
- // ErrorHandler:
- void OnConnectionError() override;
+ void ClearAuthenticationService();
+
+ void ClearInterceptor(AuthenticatingURLLoaderInterceptor* interceptor);
void OnAccountSelected(const GURL& origin,
mojo::String account,

Powered by Google App Engine
This is Rietveld 408576698