Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 118523003: More API cleanup. (Closed)

Created:
7 years ago by Sven Panne
Modified:
7 years ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

More API cleanup. * Removed String::Empty, Number::New, Integer::New, Integer::NewFromUnsigned, FunctionTemplate::New and Object::New without Isolate* parameter. * Removed Integer::New and Integer::NewUnsigned with weird argument order. Chrome CLs matching this change are prepared, BTW. LOG=y BUG=324225 R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18383

Patch Set 1 #

Patch Set 2 : Removed Integer::New and Integer::NewUnsigned with weird argument order. #

Patch Set 3 : Removed Integer::New variants without Isolate*. #

Patch Set 4 : Removed String::Empty(). #

Patch Set 5 : Removed Integer::Number variants without Isolate*. #

Patch Set 6 : Removed Integer::Number variants without Isolate*. #

Patch Set 7 : Removed commented out API entry. #

Total comments: 2

Patch Set 8 : Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+700 lines, -637 lines) Patch
M include/v8.h View 1 2 3 4 5 6 7 chunks +3 lines, -18 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 6 7 11 chunks +11 lines, -62 lines 0 comments Download
M src/d8-posix.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/cctest.h View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/profiler-extension.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 4 160 chunks +433 lines, -371 lines 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-assembler-x64.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 2 12 chunks +34 lines, -14 lines 0 comments Download
M test/cctest/test-debug.cc View 1 2 3 4 38 chunks +79 lines, -58 lines 0 comments Download
M test/cctest/test-declarative-accessors.cc View 1 2 3 4 2 chunks +9 lines, -7 lines 0 comments Download
M test/cctest/test-decls.cc View 1 2 3 4 20 chunks +46 lines, -36 lines 0 comments Download
M test/cctest/test-global-handles.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-global-object.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 2 5 chunks +13 lines, -8 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 2 3 4 8 chunks +35 lines, -30 lines 0 comments Download
M test/cctest/test-strings.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-thread-termination.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
7 years ago (2013-12-20 08:50:06 UTC) #1
dcarney
lgtm https://codereview.chromium.org/118523003/diff/100001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/118523003/diff/100001/src/api.cc#newcode888 src/api.cc:888: v8::Isolate* v8_isolate = reinterpret_cast<v8::Isolate*>(isolate); isolate->factory->NewNumberFromInt(length) ?
7 years ago (2013-12-20 08:59:01 UTC) #2
Sven Panne
Landing... https://codereview.chromium.org/118523003/diff/100001/src/api.cc File src/api.cc (right): https://codereview.chromium.org/118523003/diff/100001/src/api.cc#newcode888 src/api.cc:888: v8::Isolate* v8_isolate = reinterpret_cast<v8::Isolate*>(isolate); On 2013/12/20 08:59:01, dcarney ...
7 years ago (2013-12-20 09:10:08 UTC) #3
Sven Panne
7 years ago (2013-12-20 10:49:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #8 manually as r18383 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698