Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: src/extensions/statistics-extension.cc

Issue 118523003: More API cleanup. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Feedback Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/d8-posix.cc ('k') | test/cctest/cctest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/extensions/statistics-extension.cc
diff --git a/src/extensions/statistics-extension.cc b/src/extensions/statistics-extension.cc
index 767c9e79ffca5339ef14e69524b7d4ddd50519b3..a2e07ef2854391120d534dd21367d376cd74e273 100644
--- a/src/extensions/statistics-extension.cc
+++ b/src/extensions/statistics-extension.cc
@@ -48,7 +48,7 @@ static void AddCounter(v8::Isolate* isolate,
const char* name) {
if (counter->Enabled()) {
object->Set(v8::String::NewFromUtf8(isolate, name),
- v8::Number::New(*counter->GetInternalPointer()));
+ v8::Number::New(isolate, *counter->GetInternalPointer()));
}
}
@@ -57,7 +57,7 @@ static void AddNumber(v8::Isolate* isolate,
intptr_t value,
const char* name) {
object->Set(v8::String::NewFromUtf8(isolate, name),
- v8::Number::New(static_cast<double>(value)));
+ v8::Number::New(isolate, static_cast<double>(value)));
}
@@ -66,7 +66,7 @@ static void AddNumber64(v8::Isolate* isolate,
int64_t value,
const char* name) {
object->Set(v8::String::NewFromUtf8(isolate, name),
- v8::Number::New(static_cast<double>(value)));
+ v8::Number::New(isolate, static_cast<double>(value)));
}
@@ -82,7 +82,7 @@ void StatisticsExtension::GetCounters(
}
Counters* counters = isolate->counters();
- v8::Local<v8::Object> result = v8::Object::New();
+ v8::Local<v8::Object> result = v8::Object::New(args.GetIsolate());
#define ADD_COUNTER(name, caption) \
AddCounter(args.GetIsolate(), result, counters->name(), #name);
« no previous file with comments | « src/d8-posix.cc ('k') | test/cctest/cctest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698