Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1184523003: attachment broker wip (Closed)

Created:
5 years, 6 months ago by erikchen
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

attachment broker wip BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : Fix win compile errors. #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : Rebase. #

Patch Set 12 : Minor comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+757 lines, -313 lines) Patch
M chrome/app_shim/chrome_main_app_mode_mac.mm View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_mac.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/metro_viewer/chrome_metro_viewer_process_host_aurawin.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/service_process/service_process_control.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/service_ipc_server.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 1 2 3 4 3 chunks +9 lines, -1 line 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M components/nacl/broker/nacl_broker_listener.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download
M components/nacl/broker/nacl_broker_listener.cc View 1 2 3 4 5 6 7 8 3 chunks +4 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.h View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M components/nacl/loader/nacl_listener.h View 1 2 3 3 chunks +4 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 2 3 4 chunks +18 lines, -14 lines 0 comments Download
M components/nacl/loader/nacl_main.cc View 1 2 3 4 2 chunks +12 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_trusted_listener.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -6 lines 0 comments Download
M components/nacl/renderer/manifest_service_channel.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M components/nacl/renderer/manifest_service_channel.cc View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/renderer/trusted_plugin_channel.cc View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +8 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.h View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M content/child/child_thread_impl.cc View 1 2 3 4 5 5 chunks +19 lines, -4 lines 0 comments Download
M content/child/npapi/np_channel_base.h View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M content/child/npapi/np_channel_base.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 3 4 5 6 7 8 5 chunks +31 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 1 2 3 1 chunk +4 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_channel_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 2 3 4 5 1 chunk +5 lines, -4 lines 0 comments Download
M content/plugin/plugin_channel.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M content/plugin/plugin_channel.cc View 1 2 2 chunks +10 lines, -9 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/public/child/child_thread.h View 1 2 3 4 5 1 chunk +10 lines, -1 line 0 comments Download
M content/public/common/child_process_host.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/test/mock_render_thread.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/mock_render_thread.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/npapi/plugin_channel_host.h View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M content/renderer/npapi/plugin_channel_host.cc View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M content/renderer/npapi/webplugin_delegate_proxy.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/render_thread_impl_browser_test_ipc_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A ipc/attachment_broker.h View 1 2 3 4 5 6 7 8 9 1 chunk +54 lines, -0 lines 0 comments Download
A ipc/attachment_broker_win.h View 1 2 3 4 5 6 7 8 9 1 chunk +37 lines, -0 lines 0 comments Download
A ipc/attachment_broker_win.cc View 1 2 3 4 5 6 7 8 9 1 chunk +32 lines, -0 lines 0 comments Download
A ipc/brokerable_attachment.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +41 lines, -0 lines 0 comments Download
A ipc/handle_attachment_win.h View 1 2 3 4 5 6 7 8 9 1 chunk +23 lines, -0 lines 0 comments Download
M ipc/ipc.gypi View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc_channel.h View 1 2 3 chunks +20 lines, -7 lines 0 comments Download
M ipc/ipc_channel_common.cc View 1 1 chunk +25 lines, -12 lines 0 comments Download
M ipc/ipc_channel_factory.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M ipc/ipc_channel_factory.cc View 1 2 chunks +10 lines, -7 lines 0 comments Download
M ipc/ipc_channel_nacl.h View 1 2 3 chunks +5 lines, -1 line 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 2 3 chunks +13 lines, -5 lines 0 comments Download
M ipc/ipc_channel_posix.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 4 chunks +15 lines, -5 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 1 2 15 chunks +20 lines, -20 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 1 2 chunks +6 lines, -3 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ipc/ipc_channel_reader.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_channel_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ipc/ipc_channel_win.h View 1 2 3 4 5 6 7 2 chunks +7 lines, -2 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 2 3 4 5 6 7 4 chunks +15 lines, -6 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M ipc/ipc_perftest_support.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ipc/ipc_sync_channel.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M ipc/ipc_sync_channel.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M ipc/ipc_test_base.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.h View 1 2 chunks +6 lines, -3 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 2 3 4 5 6 7 8 9 10 9 chunks +27 lines, -16 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo_unittest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +10 lines, -9 lines 0 comments Download
M ipc/mojo/ipc_mojo_bootstrap.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M ipc/mojo/ipc_mojo_perftest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/nacl_irt/manifest_service.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/proxy/proxy_channel.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/desktop_process.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -8 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/ipc_desktop_environment_unittest.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -5 lines 0 comments Download
M remoting/host/ipc_util_posix.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +6 lines, -9 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M win8/metro_driver/chrome_app_view_ash.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +6 lines, -5 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.h View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 1 2 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184523003/180001
5 years, 6 months ago (2015-06-15 20:53:28 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/63696) mac_chromium_rel_ng on ...
5 years, 6 months ago (2015-06-15 21:00:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184523003/200001
5 years, 6 months ago (2015-06-15 21:16:56 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184523003/220001
5 years, 6 months ago (2015-06-15 21:25:09 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/82290)
5 years, 6 months ago (2015-06-15 21:38:39 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1184523003/220001
5 years, 6 months ago (2015-06-15 22:09:05 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 22:36:10 UTC) #14 
Dry run: Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Powered by Google App Engine
This is Rietveld 408576698