components/nacl/loader/nacl_trusted_listener.cc - Issue 1184523003: attachment broker wip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_trusted_listener.cc

Issue 1184523003: attachment broker wip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/nacl/loader/nacl_trusted_listener.cc

diff --git a/components/nacl/loader/nacl_trusted_listener.cc b/components/nacl/loader/nacl_trusted_listener.cc

index 76d0cee523d6462593fd4021af128e8085182a52..34912c6d81f1a5903026312a3934dfed8e5c8b5c 100644

--- a/components/nacl/loader/nacl_trusted_listener.cc

+++ b/components/nacl/loader/nacl_trusted_listener.cc

@@ -37,12 +37,11 @@ NaClTrustedListener::NaClTrustedListener(

base::SingleThreadTaskRunner* ipc_task_runner,

base::WaitableEvent* shutdown_event)

: channel_handle_(handle) {

- channel_ = IPC::SyncChannel::Create(handle,

- IPC::Channel::MODE_SERVER,

- this,

- ipc_task_runner,

- true, /* create_channel_now */

- shutdown_event).Pass();

+ // TODO(erikchen): fixme

+ channel_ =

+ IPC::SyncChannel::Create(handle, IPC::Channel::MODE_SERVER, this,

+ ipc_task_runner, true, /* create_channel_now */

+ shutdown_event, nullptr).Pass();

channel_->AddFilter(new EOFMessageFilter());

}