ppapi/nacl_irt/manifest_service.cc - Issue 1184523003: attachment broker wip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/nacl_irt/manifest_service.cc

Issue 1184523003: attachment broker wip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/nacl_irt/manifest_service.cc

diff --git a/ppapi/nacl_irt/manifest_service.cc b/ppapi/nacl_irt/manifest_service.cc

index 8a6ec1f641835bae0181f12acb432585a3a8ad62..1492db18ba7cc29ac138b9946674754009320417 100644

--- a/ppapi/nacl_irt/manifest_service.cc

+++ b/ppapi/nacl_irt/manifest_service.cc

@@ -69,9 +69,10 @@ ManifestService::ManifestService(

scoped_refptr<base::SingleThreadTaskRunner> io_task_runner,

base::WaitableEvent* shutdown_event) {

filter_ = new ManifestMessageFilter(shutdown_event);

+ // TODO(erikchen): fixme

channel_ = IPC::ChannelProxy::Create(handle, IPC::Channel::MODE_SERVER,

NULL, // Listener

- io_task_runner.get());

+ io_task_runner.get(), nullptr);

channel_->AddFilter(filter_.get());

}

« no previous file with comments | « ipc/sync_socket_unittest.cc ('k') | ppapi/nacl_irt/ppapi_dispatcher.cc » ('j') | no next file with comments »