Issue 1182933003: Verify that callers correctly set parentUsesSize if they use the child's size (and fix a few cases …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1182933003: Verify that callers correctly set parentUsesSize if they use the child's size (and fix a few cases … (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Verify that callers correctly set parentUsesSize if they use the child's size (and fix a few cases that didn't). This introduces a bunch of code that should only run in debug builds, but we don't have #ifdefs yet. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d9e4de433e33098ae16f9046a7c1900467a68b46

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -16 lines)			Patch
M	sky/engine/core/painting/Size.dart	View	1 2 3 4 5	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/examples/widgets/spinning_mixed.dart	View	1 2	2 chunks	+1 line, -5 lines	0 comments	Download
M	sky/sdk/BUILD.gn	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	sky/sdk/lib/framework/debug/utils.dart	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/box.dart	View	1 2	7 chunks	+47 lines, -8 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/object.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/framework/rendering/paragraph.dart	View		1 chunk	+7 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

abarth-chromium

LGTM as long as we don't actually new up a _DebugSize outside of checked mode...

5 years, 6 months ago (2015-06-12 23:59:33 UTC) #2

Hixie

5 years, 6 months ago (2015-06-13 00:10:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #6 (id:100001) manually as
d9e4de433e33098ae16f9046a7c1900467a68b46 (presubmit successful).