Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: sky/sdk/lib/framework/rendering/paragraph.dart

Issue 1182933003: Verify that callers correctly set parentUsesSize if they use the child's size (and fix a few cases … (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/sdk/lib/framework/rendering/object.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import 'dart:sky' as sky; 5 import 'dart:sky' as sky;
6 import 'box.dart'; 6 import 'box.dart';
7 import 'object.dart'; 7 import 'object.dart';
8 8
9 class RenderInline extends RenderObject { 9 class RenderInline extends RenderObject {
10 RenderInline(this.data); 10 RenderInline(this.data);
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 TextAlign.right: 'right', 204 TextAlign.right: 'right',
205 TextAlign.center: 'center', 205 TextAlign.center: 'center',
206 }[style.textAlign]; 206 }[style.textAlign];
207 } 207 }
208 } 208 }
209 _layoutRoot.paint(canvas); 209 _layoutRoot.paint(canvas);
210 } 210 }
211 211
212 // we should probably expose a way to do precise (inter-glpyh) hit testing 212 // we should probably expose a way to do precise (inter-glpyh) hit testing
213 213
214 String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings( prefix)}${prefix}style:\n${style.toString("$prefix ")}\n${prefix}text: ${text}\ n'; 214 String debugDescribeSettings(String prefix) {
215 String result = '${super.debugDescribeSettings(prefix)}';
216 if (style != null)
217 result += '${prefix}style:\n' + style.toString('$prefix ') + '\n';
218 result += '${prefix}text: ${text}\n';
219 return result;
220 }
215 } 221 }
OLDNEW
« no previous file with comments | « sky/sdk/lib/framework/rendering/object.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698