Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: sky/sdk/lib/framework/rendering/paragraph.dart

Issue 1182933003: Verify that callers correctly set parentUsesSize if they use the child's size (and fix a few cases … (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/sdk/lib/framework/rendering/object.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/rendering/paragraph.dart
diff --git a/sky/sdk/lib/framework/rendering/paragraph.dart b/sky/sdk/lib/framework/rendering/paragraph.dart
index 16caee3a9d99b5ef995d21a043bd51961bdbe8e1..3643ebb2120e194cdb202cf24cb00f7a8ee527c8 100644
--- a/sky/sdk/lib/framework/rendering/paragraph.dart
+++ b/sky/sdk/lib/framework/rendering/paragraph.dart
@@ -211,5 +211,11 @@ class RenderParagraph extends RenderBox {
// we should probably expose a way to do precise (inter-glpyh) hit testing
- String debugDescribeSettings(String prefix) => '${super.debugDescribeSettings(prefix)}${prefix}style:\n${style.toString("$prefix ")}\n${prefix}text: ${text}\n';
+ String debugDescribeSettings(String prefix) {
+ String result = '${super.debugDescribeSettings(prefix)}';
+ if (style != null)
+ result += '${prefix}style:\n' + style.toString('$prefix ') + '\n';
+ result += '${prefix}text: ${text}\n';
+ return result;
+ }
}
« no previous file with comments | « sky/sdk/lib/framework/rendering/object.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698