Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: pkg/unittest/lib/html_layout_config.dart

Issue 11829045: Cleaning up unittest configurations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/unittest/lib/html_layout_config.dart
diff --git a/pkg/unittest/lib/html_layout_config.dart b/pkg/unittest/lib/html_layout_config.dart
index a452e7934ea697b1bdba217481f8a0e78a898cc0..bd809c02dec6e43db0d7595fc6369bb8d32df521 100644
--- a/pkg/unittest/lib/html_layout_config.dart
+++ b/pkg/unittest/lib/html_layout_config.dart
@@ -148,8 +148,11 @@ class ChildHtmlConfiguration extends Configuration {
_Message.text(testCase.result, elapsed, testCase.message), '*');
}
- void onDone(int passed, int failed, int errors, List<TestCase> results,
- String uncaughtError) {
+ void onSummary(int passed, int failed, int errors, List<TestCase> results,
+ String uncaughtError) {
+ }
+
+ void onDone(bool success) {
window.on.error.remove(_onErrorClosure);
}
}
@@ -274,8 +277,10 @@ class ParentHtmlConfiguration extends Configuration {
'${testCase.description}//${testCase.message}';
}
- void onDone(int passed, int failed, int errors, List<TestCase> results,
+ void onSummary(int passed, int failed, int errors, List<TestCase> results,
String uncaughtError) {
+ }
+ void onDone(bool success) {
window.on.message.remove(_messageHandler);
window.on.error.remove(_onErrorClosure);
window.postMessage('done', '*'); // Unblock DRT

Powered by Google App Engine
This is Rietveld 408576698