Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pkg/unittest/lib/html_enhanced_config.dart

Issue 11829045: Cleaning up unittest configurations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/unittest/lib/html_config.dart ('k') | pkg/unittest/lib/html_layout_config.dart » ('j') | pkg/unittest/lib/vm_config.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/html_enhanced_config.dart
diff --git a/pkg/unittest/lib/html_enhanced_config.dart b/pkg/unittest/lib/html_enhanced_config.dart
index 91309dfbaf6cb65985efceb8193c9405163b38f8..94e097401c151f65350733d02bb6421d06531da5 100644
--- a/pkg/unittest/lib/html_enhanced_config.dart
+++ b/pkg/unittest/lib/html_enhanced_config.dart
@@ -76,13 +76,14 @@ class HtmlEnhancedConfiguration extends Configuration {
void onTestResult(TestCase testCase) {}
- void onDone(int passed, int failed, int errors, List<TestCase> results,
+ void onSummary(int passed, int failed, int errors, List<TestCase> results,
String uncaughtError) {
- _uninstallHandlers();
-
_showInteractiveResultsInPage(passed, failed, errors, results,
_isLayoutTest, uncaughtError);
+ }
+ void onDone(bool success) {
+ _uninstallHandlers();
window.postMessage('unittest-suite-done', '*');
}
« no previous file with comments | « pkg/unittest/lib/html_config.dart ('k') | pkg/unittest/lib/html_layout_config.dart » ('j') | pkg/unittest/lib/vm_config.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698