Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: pkg/unittest/lib/interactive_html_config.dart

Issue 11829045: Cleaning up unittest configurations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/unittest/lib/interactive_html_config.dart
diff --git a/pkg/unittest/lib/interactive_html_config.dart b/pkg/unittest/lib/interactive_html_config.dart
index 796fcd46832993b9a6bb8407779e6c32cf7689dc..fa3c283bbc09b3c90483b3feda1869a2696351fb 100644
--- a/pkg/unittest/lib/interactive_html_config.dart
+++ b/pkg/unittest/lib/interactive_html_config.dart
@@ -160,9 +160,11 @@ class ChildInteractiveHtmlConfiguration extends HtmlConfiguration {
parentWindow.postMessage(
_Message.text(testCase.result, elapsed, testCase.message), '*');
}
+ void onSummary(int passed, int failed, int errors, List<TestCase> results,
+ String uncaughtError) {
+ }
- void onDone(int passed, int failed, int errors, List<TestCase> results,
- String uncaughtError) {
+ void onDone(bool success) {
_uninstallErrorHandler();
}
}
@@ -407,8 +409,11 @@ class ParentInteractiveHtmlConfiguration extends HtmlConfiguration {
actions.style.display = 'none';
}
- void onDone(int passed, int failed, int errors, List<TestCase> results,
+ void onSummary(int passed, int failed, int errors, List<TestCase> results,
String uncaughtError) {
+ }
+
+ void onDone(bool success) {
window.on.message.remove(_messageHandler);
_uninstallErrorHandler();
document.query('#busy').style.display = 'none';

Powered by Google App Engine
This is Rietveld 408576698