Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 118283003: Make Widget::Show() creates active windows. (Closed)

Created:
7 years ago by mlamouri (slow - plz ping)
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, ben+views_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make Widget::Show() creates active windows. It is actually what this is doing in practice but only because SHOW_STATE_INACTIVE implementation is broken and usually creates active windows. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243590

Patch Set 1 #

Patch Set 2 : autofill needs an inactive widget #

Patch Set 3 : more ShowInactive() calls #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -10 lines) Patch
M chrome/browser/ui/views/autofill/autofill_popup_view_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/fullscreen_exit_bubble_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/status_bubble_views.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_host.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 chunks +40 lines, -1 line 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
mlamouri (slow - plz ping)
This patch is applying what sky asked for in cl 109473003 with regard to Widget::Show() ...
7 years ago (2013-12-20 14:48:52 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-06 17:32:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/118283003/1
6 years, 11 months ago (2014-01-06 19:22:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=241983
6 years, 11 months ago (2014-01-06 22:09:08 UTC) #4
mlamouri (slow - plz ping)
sky@, could you PTAL at this. I have changed some Widget::Show() calls to Widget::ShowInactive() in ...
6 years, 11 months ago (2014-01-08 14:21:44 UTC) #5
sky
SLGTM
6 years, 11 months ago (2014-01-08 15:18:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/118283003/360001
6 years, 11 months ago (2014-01-08 15:58:02 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 17:28:28 UTC) #8
Message was sent while issue was closed.
Change committed as 243590

Powered by Google App Engine
This is Rietveld 408576698