chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc - Issue 118283003: Make Widget::Show() creates active windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

Issue 118283003: Make Widget::Show() creates active windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more ShowInactive() calls Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

index e0301aceb4989b03e7a8f7ffb0a988a035f1aad3..3a4b819674718e5272b8375d875dd4cc8a12d107 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc

@@ -226,7 +226,7 @@ void OmniboxPopupContentsView::UpdatePopupAppearance() {

// window showing.

return;

}

- popup_->Show();

+ popup_->ShowInactive();

} else {

// Animate the popup shrinking, but don't animate growing larger since that

// would make the popup feel less responsive.