ui/views/controls/menu/menu_host.cc - Issue 118283003: Make Widget::Show() creates active windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_host.cc

Issue 118283003: Make Widget::Show() creates active windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more ShowInactive() calls Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_host.cc

diff --git a/ui/views/controls/menu/menu_host.cc b/ui/views/controls/menu/menu_host.cc

index 4645e1ba6aabef05354fc2f3b78b5dd255fea71c..61e3f3818532138c8bec5d9d532f22044f8bec8a 100644

--- a/ui/views/controls/menu/menu_host.cc

+++ b/ui/views/controls/menu/menu_host.cc

@@ -76,7 +76,7 @@ void MenuHost::ShowMenuHost(bool do_capture) {

// Doing a capture may make us get capture lost. Ignore it while we're in the

// process of showing.

base::AutoReset<bool> reseter(&ignore_capture_lost_, true);

- Show();

+ ShowInactive();

if (do_capture) {

#if defined(USE_AURA)

// Cancel existing touches, so we don't miss some touch release/cancel