Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1986)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11826048: Revert 176015 (Closed)

Created:
7 years, 11 months ago by ricow1
Modified:
7 years, 11 months ago
CC:
chromium-reviews, akalin, Raghu Simha, sail+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, pam+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, haitaol1, stevenjb+watch_chromium.org, tim (not reviewing), nkostylev+watch_chromium.org
Visibility:
Public.

Description

Revert 176015 > Run the JSON Schema Compiler's bundle compilation on JSON files. Previously it > was only run on IDL files. Clean up all the code which that simplifies. > > TBR=isherman@chromium.org,battre@chromium.org,akalin@chromium.org > BUG=141318 > > Review URL: https://chromiumcodereview.appspot.com/11747025 This seems to be causing complation failures on release win builders: http://chromegw/i/chromium.chrome/builders/Google%20Chrome%20Win/builds/15702 TBR=kalman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+755 lines, -11883 lines) Patch
M build/json_schema_bundle_compile.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M build/json_schema_compile.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.h View 4 chunks +16 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api.cc View 10 chunks +27 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_handler_api_test.cc View 8 chunks +21 lines, -29 lines 0 comments Download
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth/bluetooth_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/extensions/api/bookmarks/bookmark_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/bookmarks/bookmark_api.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/api/bookmarks/bookmark_api_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/api/bookmarks/bookmarks_api.h View 1 chunk +0 lines, -321 lines 0 comments Download
D chrome/browser/extensions/api/bookmarks/bookmarks_api.cc View 1 chunk +0 lines, -996 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc View 4 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.h View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 6 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/context_menu/context_menu_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/context_menu/context_menu_api.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/context_menu/context_menu_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/extensions/api/context_menus/context_menu_apitest.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/extensions/api/context_menus/context_menus_api.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/extensions/api/context_menus/context_menus_api.cc View 1 chunk +0 lines, -398 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.h View 4 chunks +29 lines, -37 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 5 chunks +22 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.h View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/api/history/history_api.cc View 11 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.h View 4 chunks +16 lines, -17 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api.cc View 13 chunks +24 lines, -25 lines 0 comments Download
M chrome/browser/extensions/api/management/management_api_browsertest.cc View 6 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_api.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/extensions/api/permissions/permissions_apitest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/processes/processes_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/record/record_api.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/record/record_api.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/record/record_api_test.cc View 3 chunks +6 lines, -8 lines 0 comments Download
D chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/extensions/api/storage/managed_value_store_cache.h View 1 chunk +0 lines, -154 lines 0 comments Download
D chrome/browser/extensions/api/storage/managed_value_store_cache.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D chrome/browser/extensions/api/storage/policy_value_store.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/extensions/api/storage/policy_value_store.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D chrome/browser/extensions/api/storage/policy_value_store_unittest.cc View 1 chunk +0 lines, -217 lines 0 comments Download
D chrome/browser/extensions/api/storage/setting_sync_data.h View 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/extensions/api/storage/setting_sync_data.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_apitest.cc View 1 chunk +0 lines, -518 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_backend.h View 1 chunk +0 lines, -116 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_backend.cc View 1 chunk +0 lines, -285 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_frontend.h View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_frontend.cc View 1 chunk +0 lines, -218 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_frontend_unittest.cc View 1 chunk +0 lines, -288 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_namespace.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_namespace.cc View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_observer.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_quota_unittest.cc View 1 chunk +0 lines, -594 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_storage_factory.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc View 1 chunk +0 lines, -235 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_sync_processor.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_sync_processor.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_sync_unittest.cc View 1 chunk +0 lines, -1425 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_sync_util.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_sync_util.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_test_util.h View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/extensions/api/storage/settings_test_util.cc View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/browser/extensions/api/storage/storage_api.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/extensions/api/storage/storage_api.cc View 1 chunk +0 lines, -286 lines 0 comments Download
D chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D chrome/browser/extensions/api/storage/syncable_settings_storage.h View 1 chunk +0 lines, -111 lines 0 comments Download
D chrome/browser/extensions/api/storage/syncable_settings_storage.cc View 1 chunk +0 lines, -384 lines 0 comments Download
D chrome/browser/extensions/api/storage/value_store_cache.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/extensions/api/storage/value_store_cache.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc View 1 chunk +0 lines, -67 lines 0 comments Download
A + chrome/browser/extensions/api/tabs/execute_code_in_tab_function.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/tabs/tabs.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/api/tabs/tabs.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/extensions/api/tabs/tabs_api.h View 1 chunk +0 lines, -290 lines 0 comments Download
D chrome/browser/extensions/api/tabs/tabs_api.cc View 1 chunk +0 lines, -2136 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_interactive_test.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 30 chunks +34 lines, -36 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/browser_event_router.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/content_script_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/data_deleter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 12 chunks +178 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/settings/leveldb_settings_storage_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/leveldb_settings_storage_factory.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/managed_value_store_cache.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/managed_value_store_cache.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/policy_value_store.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/policy_value_store.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/policy_value_store_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/setting_sync_data.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/setting_sync_data.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_api.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_api.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_backend.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_backend.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_frontend.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_frontend.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_frontend_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_namespace.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_namespace.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_quota_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_storage_factory.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_storage_quota_enforcer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_storage_quota_enforcer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_sync_processor.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_sync_processor.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_sync_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_sync_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_sync_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_test_util.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/settings_test_util.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/sync_or_local_value_store_cache.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/sync_or_local_value_store_cache.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/syncable_settings_storage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/syncable_settings_storage.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/value_store_cache.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/value_store_cache.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/weak_unlimited_settings_storage.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/settings/weak_unlimited_settings_storage.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/performance_monitor/performance_monitor.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/chrome_extensions_activity_monitor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/chrome_extensions_activity_monitor_unittest.cc View 6 chunks +16 lines, -18 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/test/integration/extension_settings_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 7 chunks +44 lines, -43 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 2 chunks +30 lines, -25 lines 0 comments Download
M chrome/common/extensions/api/content_settings.json View 1 chunk +0 lines, -3 lines 0 comments Download
MM chrome/common/extensions/api/events.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 9 chunks +40 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handler_internal.json View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/i18n.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/storage.json View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/windows.json View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/server2/api_data_source.py View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 2 chunks +20 lines, -0 lines 0 comments Download
M tools/json_schema_compiler/code.py View 1 chunk +3 lines, -5 lines 0 comments Download
M tools/json_schema_compiler/compiler.py View 2 chunks +3 lines, -8 lines 0 comments Download
M tools/json_schema_compiler/model.py View 6 chunks +13 lines, -63 lines 0 comments Download
M tools/json_schema_compiler/schema_bundle_generator.py View 5 chunks +5 lines, -51 lines 0 comments Download
M tools/json_schema_compiler/test/json_schema_compiler_tests.gyp View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ricow1
7 years, 11 months ago (2013-01-10 10:35:19 UTC) #1 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698