Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4044)

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store.cc

Issue 11826048: Revert 176015 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/policy_value_store.cc
===================================================================
--- chrome/browser/extensions/api/storage/policy_value_store.cc (revision 176046)
+++ chrome/browser/extensions/api/storage/policy_value_store.cc (working copy)
@@ -1,163 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/extensions/api/storage/policy_value_store.h"
-
-#include "base/logging.h"
-#include "base/values.h"
-#include "chrome/browser/extensions/api/storage/settings_namespace.h"
-#include "chrome/browser/policy/policy_map.h"
-#include "chrome/browser/policy/policy_types.h"
-#include "chrome/browser/value_store/value_store_change.h"
-#include "content/public/browser/browser_thread.h"
-
-using content::BrowserThread;
-
-namespace extensions {
-
-namespace {
-
-const char kReadOnlyStoreErrorMessage[] = "This is a read-only store.";
-
-ValueStore::WriteResult WriteResultError() {
- return ValueStore::MakeWriteResult(kReadOnlyStoreErrorMessage);
-}
-
-} // namespace
-
-PolicyValueStore::PolicyValueStore(
- const std::string& extension_id,
- const scoped_refptr<SettingsObserverList>& observers,
- scoped_ptr<ValueStore> delegate)
- : extension_id_(extension_id),
- observers_(observers),
- delegate_(delegate.Pass()) {}
-
-PolicyValueStore::~PolicyValueStore() {}
-
-void PolicyValueStore::SetCurrentPolicy(const policy::PolicyMap& policy,
- bool notify_if_changed) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
- // Convert |policy| to a dictionary value. Only include mandatory policies
- // for now.
- base::DictionaryValue current_policy;
- for (policy::PolicyMap::const_iterator it = policy.begin();
- it != policy.end(); ++it) {
- if (it->second.level == policy::POLICY_LEVEL_MANDATORY) {
- current_policy.SetWithoutPathExpansion(
- it->first, it->second.value->DeepCopy());
- }
- }
-
- // Get the previous policies stored in the database.
- // TODO(joaodasilva): it'd be better to have a less expensive way of
- // determining which keys are currently stored, or of determining which keys
- // must be removed.
- base::DictionaryValue previous_policy;
- ValueStore::ReadResult read_result = delegate_->Get();
- if (read_result->HasError()) {
- LOG(WARNING) << "Failed to read managed settings for extension "
- << extension_id_ << ": " << read_result->error();
- // Leave |previous_policy| empty, so that events are generated for every
- // policy in |current_policy|.
- } else {
- read_result->settings()->Swap(&previous_policy);
- }
-
- // Now get two lists of changes: changes after setting the current policies,
- // and changes after removing old policies that aren't in |current_policy|
- // anymore.
- std::vector<std::string> removed_keys;
- for (base::DictionaryValue::Iterator it(previous_policy);
- it.HasNext(); it.Advance()) {
- if (!current_policy.HasKey(it.key()))
- removed_keys.push_back(it.key());
- }
-
- ValueStoreChangeList changes;
-
- WriteResult result = delegate_->Remove(removed_keys);
- if (!result->HasError()) {
- changes.insert(
- changes.end(), result->changes().begin(), result->changes().end());
- }
-
- // IGNORE_QUOTA because these settings aren't writable by the extension, and
- // are configured by the domain administrator.
- ValueStore::WriteOptions options = ValueStore::IGNORE_QUOTA;
- result = delegate_->Set(options, current_policy);
- if (!result->HasError()) {
- changes.insert(
- changes.end(), result->changes().begin(), result->changes().end());
- }
-
- if (!changes.empty() && notify_if_changed) {
- observers_->Notify(
- &SettingsObserver::OnSettingsChanged,
- extension_id_,
- settings_namespace::MANAGED,
- ValueStoreChange::ToJson(changes));
- }
-}
-
-void PolicyValueStore::DeleteStorage() {
- // This is called from our owner, indicating that storage for this extension
- // should be removed.
- delegate_->Clear();
-}
-
-size_t PolicyValueStore::GetBytesInUse(const std::string& key) {
- // LeveldbValueStore doesn't implement this; and the underlying database
- // isn't acccessible to the extension in any case; from the extension's
- // perspective this is a read-only store.
- return 0;
-}
-
-size_t PolicyValueStore::GetBytesInUse(const std::vector<std::string>& keys) {
- // See note above.
- return 0;
-}
-
-size_t PolicyValueStore::GetBytesInUse() {
- // See note above.
- return 0;
-}
-
-ValueStore::ReadResult PolicyValueStore::Get(const std::string& key) {
- return delegate_->Get(key);
-}
-
-ValueStore::ReadResult PolicyValueStore::Get(
- const std::vector<std::string>& keys) {
- return delegate_->Get(keys);
-}
-
-ValueStore::ReadResult PolicyValueStore::Get() {
- return delegate_->Get();
-}
-
-ValueStore::WriteResult PolicyValueStore::Set(
- WriteOptions options, const std::string& key, const base::Value& value) {
- return WriteResultError();
-}
-
-ValueStore::WriteResult PolicyValueStore::Set(
- WriteOptions options, const base::DictionaryValue& settings) {
- return WriteResultError();
-}
-
-ValueStore::WriteResult PolicyValueStore::Remove(const std::string& key) {
- return WriteResultError();
-}
-
-ValueStore::WriteResult PolicyValueStore::Remove(
- const std::vector<std::string>& keys) {
- return WriteResultError();
-}
-
-ValueStore::WriteResult PolicyValueStore::Clear() {
- return WriteResultError();
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698