[Android] Respect margin values for CompositorViewHolder child view.

[Android] Respect margin values for CompositorViewHolder child view.

This patch itself doesn't have any visible change, but it will
enable CompositorViewHolder children to use margin values.

BUG=499415
Committed: https://crrev.com/63a6e5637e8ed12ed78399b19fc9de23369fd677
Cr-Commit-Position: refs/heads/master@{#334437}

[Kibeom Kim (inactive), 2015-06-12 21:21:44]

kkimlabs@chromium.org changed reviewers:
+ dtrainor@chromium.org, ianwen@chromium.org, tedchoc@chromium.org

[Kibeom Kim (inactive), 2015-06-12 21:21:44]

Question:

Ideally we want to set a background color for mManager.getView() in here
https://codereview.chromium.org/1184613002/diff/20001/chrome/android/java_sta...
, but it needs to have tap strip offset from the top. So currently it's done by
padding but then background paints over it. So I'm trying to make
CompositorViewHolder.java support margin.

Does this approach look OK? (note: another issue I need to handle in this CL is
making touch offset respect the margin.)

Otherwise, I can workaround by nesting a frame layout at
https://codereview.chromium.org/1184613002/diff/20001/chrome/android/java_sta...
instead.

[Kibeom Kim (inactive), 2015-06-12 22:02:56]

OK ready for review. Actually I like it and IMHO it's actually more correct.

[Kibeom Kim (inactive), 2015-06-12 22:05:49]

https://codereview.chromium.org/1182453003/diff/20002/chrome/android/java_sta...
File
chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
(right):

https://codereview.chromium.org/1182453003/diff/20002/chrome/android/java_sta...
chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java:167:
e.offsetLocation(-view.getLeft(), -view.getTop());
Note: this is how ViewGroup deals with touch pointer offset. (except that it
doesn't take account scrollX/Y)
http://androidxref.com/5.0.0_r2/xref/frameworks/base/core/java/android/view/V...

[David Trainor- moved to gerrit, 2015-06-15 16:48:12]

lgtm, just make sure we're not double counting any offsets for things like
infobars, normal ContentViewCores, etc..  This is mainly because (IIRC) we also
offset the touch events for the top controls height if necessary (which might
actually be the margin height too?).  So just check all those cases :).

[Kibeom Kim (inactive), 2015-06-15 18:58:15]

kkimlabs@chromium.org changed reviewers:
+ twellington@chromium.org

[Kibeom Kim (inactive), 2015-06-15 19:08:52]

On 2015/06/15 16:48:12, David Trainor wrote:
> lgtm, just make sure we're not double counting any offsets for things like
> infobars, normal ContentViewCores, etc..  This is mainly because (IIRC) we
also
> offset the touch events for the top controls height if necessary (which might
> actually be the margin height too?).  So just check all those cases :).

Just checked Infobar and ContentView.

Short answer: It works correctly.
Long answer:
The view margin offset I'm compensating is a parent of Infobar or ContentView,
and it is is maximized covering the tap strip, and margins are zero in those
cases. If I set left margin forcefully, the touch offset works correctly on
InfoBar. It looks incorrect on ContentView, but I noticed that ContentView
Android View and actual displayed location is different in that case so that's
another thing.

[Kibeom Kim (inactive), 2015-06-15 19:08:57]

The CQ bit was checked by kkimlabs@chromium.org

[commit-bot: I haz the power, 2015-06-15 19:09:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1182453003/20002

[commit-bot: I haz the power, 2015-06-15 19:34:48]

Committed patchset #3 (id:20002)

[commit-bot: I haz the power, 2015-06-15 19:35:37]

Patchset 3 (id:??) landed as
https://crrev.com/63a6e5637e8ed12ed78399b19fc9de23369fd677
Cr-Commit-Position: refs/heads/master@{#334437}