Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java

Issue 1182453003: [Android] Respect margin values for CompositorViewHolder child view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Make LayoutManager handle touch offset Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
index 1853e55e3dd22c20e9eb8144bc34ab822e976609..196649d1008de8e36d8969fb0704cac336f05679 100644
--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkPage.java
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser.enhancedbookmarks;
import android.app.Activity;
import android.content.res.Resources;
import android.view.View;
+import android.view.ViewGroup.MarginLayoutParams;
import com.google.android.apps.chrome.R;
@@ -47,8 +48,14 @@ public class EnhancedBookmarkPage implements NativePage, EnhancedBookmarkStateCh
mManager = new EnhancedBookmarkManager(mActivity);
Resources res = mActivity.getResources();
- mManager.getView().setPadding(0, res.getDimensionPixelSize(R.dimen.tab_strip_height)
- + res.getDimensionPixelSize(R.dimen.toolbar_height_no_shadow), 0, 0);
+
+ MarginLayoutParams layoutParams = new MarginLayoutParams(
+ MarginLayoutParams.MATCH_PARENT, MarginLayoutParams.MATCH_PARENT);
+ layoutParams.setMargins(0,
+ res.getDimensionPixelSize(R.dimen.tab_strip_height)
+ + res.getDimensionPixelSize(R.dimen.toolbar_height_no_shadow),
+ 0, 0);
+ mManager.getView().setLayoutParams(layoutParams);
mManager.setUrlChangeListener(this);
}

Powered by Google App Engine
This is Rietveld 408576698