chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java - Issue 1182453003: [Android] Respect margin values for CompositorViewHolder child view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

Issue 1182453003: [Android] Respect margin values for CompositorViewHolder child view. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make LayoutManager handle touch offset Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java » ('j') | chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

index 2d4e56c47ccb0a8db09632b6cb6c1f46b34f369e..0ac5519bea2617d71dd307999104a31456f716a7 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java

@@ -813,7 +813,16 @@ public class CompositorViewHolder extends FrameLayout

FrameLayout.LayoutParams layoutParams = new FrameLayout.LayoutParams(

LayoutParams.MATCH_PARENT, LayoutParams.MATCH_PARENT);

+ if (mView.getLayoutParams() instanceof MarginLayoutParams) {

+ MarginLayoutParams existingLayoutParams =

+ (MarginLayoutParams) mView.getLayoutParams();

+ layoutParams.leftMargin = existingLayoutParams.leftMargin;

+ layoutParams.rightMargin = existingLayoutParams.rightMargin;

+ layoutParams.topMargin = existingLayoutParams.topMargin;

+ layoutParams.bottomMargin = existingLayoutParams.bottomMargin;

+ }

addView(mView, layoutParams);

setFocusable(false);

setFocusableInTouchMode(false);