Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1181813002: Reland of Use the LookupIterator in SetAccessor (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Use the LookupIterator in SetAccessor (patchset #1 id:1 of https://codereview.chromium.org/1175323004/) Reason: Didn't break anything Original issue's description: > Revert of Use the LookupIterator in SetAccessor (patchset #2 id:20001 of https://codereview.chromium.org/1178673003/) > > Reason for revert: > Blocks reverting of https://codereview.chromium.org/1175973002 > > Original issue's description: > > Use the LookupIterator in SetAccessor > > > > BUG=v8:4137 > > LOG=n > > > > Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 > > Cr-Commit-Position: refs/heads/master@{#28955} > > TBR=jkummerow@chromium.org,verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4137 > > Committed: https://crrev.com/11dbd29de57b290ee8dac2a782a53f879beb416f > Cr-Commit-Position: refs/heads/master@{#28956} TBR=jkummerow@chromium.org,ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4137 Committed: https://crrev.com/848b620bebd327c6895d0f5af51c8c44308fd337 Cr-Commit-Position: refs/heads/master@{#28967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -72 lines) Patch
M src/objects.cc View 1 chunk +35 lines, -58 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +40 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
Created Revert of Revert of Use the LookupIterator in SetAccessor
5 years, 6 months ago (2015-06-11 20:20:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181813002/1
5 years, 6 months ago (2015-06-11 20:20:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 20:20:51 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 20:21:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/848b620bebd327c6895d0f5af51c8c44308fd337
Cr-Commit-Position: refs/heads/master@{#28967}

Powered by Google App Engine
This is Rietveld 408576698