Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1178673003: Use the LookupIterator in SetAccessor (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use the LookupIterator in SetAccessor BUG=v8:4137 LOG=n Committed: https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 Cr-Commit-Position: refs/heads/master@{#28955}

Patch Set 1 #

Patch Set 2 : Make sure we propagate the exception rather than just returning object #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -67 lines) Patch
M src/objects.cc View 1 1 chunk +30 lines, -53 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +40 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
ptal I additionally updated the related test to except exceptions to be thrown. Testing the ...
5 years, 6 months ago (2015-06-11 12:02:59 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-11 13:39:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1178673003/20001
5 years, 6 months ago (2015-06-11 16:30:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-11 17:03:54 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/f93276bfe093f576595c5dcac69cf8f9163915d9 Cr-Commit-Position: refs/heads/master@{#28955}
5 years, 6 months ago (2015-06-11 17:04:07 UTC) #7
Igor Sheludko
5 years, 6 months ago (2015-06-11 17:19:38 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1175323004/ by ishell@chromium.org.

The reason for reverting is: Blocks reverting of
https://codereview.chromium.org/1175973002.

Powered by Google App Engine
This is Rietveld 408576698