Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 11818007: Breakpad: Add a test for crashes in the browser process (Closed)

Created:
7 years, 11 months ago by Mark Seaborn
Modified:
7 years, 11 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Breakpad: Add a test for crashes in the browser process Use "--crash-test" to generate a crash in the browser process and check that it produces a Breakpad crash dump. This is in preparation for compiling Breakpad into Linux Chromium by default, so that I will be able to check that crash_dump_tester.py finds crash dumps OK on Linux. We extend crash_dump_tester.py to launch both 32-bit and 64-bit versions of crash_service.exe on Windows, so that we can get crash dumps from the 32-bit browser process even on 64-bit systems. We introduce the cleanups_funcs list to make this cleaner. This is not the best place to put Breakpad tests, but Chrome doesn't have any other adequate framework for testing Breakpad at the moment. BUG=105778 TEST=nacl_integration Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175701

Patch Set 1 #

Total comments: 2

Patch Set 2 : Closing HTML tag + fail message #

Total comments: 4

Patch Set 3 : Review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -51 lines) Patch
A ppapi/native_client/tests/breakpad_crash_test/browser_process_crash.html View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
M ppapi/native_client/tests/breakpad_crash_test/crash_dump_tester.py View 5 chunks +65 lines, -51 lines 0 comments Download
M ppapi/native_client/tests/breakpad_crash_test/nacl.scons View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M ppapi/native_client/tools/browser_tester/browser_tester.py View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
7 years, 11 months ago (2013-01-08 23:59:16 UTC) #1
Nick Bray (chromium)
LGTM https://codereview.chromium.org/11818007/diff/1/ppapi/native_client/tests/breakpad_crash_test/browser_process_crash.html File ppapi/native_client/tests/breakpad_crash_test/browser_process_crash.html (right): https://codereview.chromium.org/11818007/diff/1/ppapi/native_client/tests/breakpad_crash_test/browser_process_crash.html#newcode34 ppapi/native_client/tests/breakpad_crash_test/browser_process_crash.html:34: </script> </body> </html> https://codereview.chromium.org/11818007/diff/5001/ppapi/native_client/tests/breakpad_crash_test/nacl.scons File ppapi/native_client/tests/breakpad_crash_test/nacl.scons (right): https://codereview.chromium.org/11818007/diff/5001/ppapi/native_client/tests/breakpad_crash_test/nacl.scons#newcode34 ...
7 years, 11 months ago (2013-01-09 01:22:02 UTC) #2
Mark Seaborn
7 years, 11 months ago (2013-01-09 03:24:12 UTC) #3
https://codereview.chromium.org/11818007/diff/1/ppapi/native_client/tests/bre...
File ppapi/native_client/tests/breakpad_crash_test/browser_process_crash.html
(right):

https://codereview.chromium.org/11818007/diff/1/ppapi/native_client/tests/bre...
ppapi/native_client/tests/breakpad_crash_test/browser_process_crash.html:34:
</script>
On 2013/01/09 01:22:02, Nick Bray (chromium) wrote:
> </body>
> </html>

Done.

https://codereview.chromium.org/11818007/diff/5001/ppapi/native_client/tests/...
File ppapi/native_client/tests/breakpad_crash_test/nacl.scons (right):

https://codereview.chromium.org/11818007/diff/5001/ppapi/native_client/tests/...
ppapi/native_client/tests/breakpad_crash_test/nacl.scons:34:
browser_flags=['--crash-test'],
On 2013/01/09 01:22:02, Nick Bray (chromium) wrote:
> Add a comment.

Done.

https://codereview.chromium.org/11818007/diff/5001/ppapi/native_client/tests/...
File ppapi/native_client/tests/breakpad_crash_test/untrusted_crash.html (right):

https://codereview.chromium.org/11818007/diff/5001/ppapi/native_client/tests/...
ppapi/native_client/tests/breakpad_crash_test/untrusted_crash.html:68: </body>
On 2013/01/09 01:22:02, Nick Bray (chromium) wrote:
> Wrong file.  Fix other file.

Done.

Powered by Google App Engine
This is Rietveld 408576698