Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: ppapi/native_client/tools/browser_tester/browser_tester.py

Issue 11818007: Breakpad: Add a test for crashes in the browser process (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/native_client/tests/breakpad_crash_test/nacl.scons ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tools/browser_tester/browser_tester.py
diff --git a/ppapi/native_client/tools/browser_tester/browser_tester.py b/ppapi/native_client/tools/browser_tester/browser_tester.py
index 1617210f4d66000796af7bb00b3c29ba863b8089..68a99b15f74a15b621e0315c374c45a7808e60b4 100755
--- a/ppapi/native_client/tools/browser_tester/browser_tester.py
+++ b/ppapi/native_client/tools/browser_tester/browser_tester.py
@@ -131,6 +131,11 @@ def BuildArgParser():
parser.add_option('--nacl_exe_stderr', dest='nacl_exe_stderr',
type='string', default=None,
help='Redirect standard error of NaCl executable.')
+ parser.add_option('--expect_browser_process_crash',
+ dest='expect_browser_process_crash',
+ action='store_true',
+ help='Do not signal a failure if the browser process '
+ 'crashes')
return parser
@@ -251,6 +256,8 @@ def RunTestsOnce(url, options):
try:
while server.test_in_progress or options.interactive:
if not browser.IsRunning():
+ if options.expect_browser_process_crash:
+ break
listener.ServerError('Browser process ended during test '
'(return code %r)' % browser.GetReturnCode())
# If Chrome exits prematurely without making a single request to the
« no previous file with comments | « ppapi/native_client/tests/breakpad_crash_test/nacl.scons ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698